Bug 175301 - Avoid a hash lookup in FilterInfo::remove()
Summary: Avoid a hash lookup in FilterInfo::remove()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-07 16:22 PDT by Simon Fraser (smfr)
Modified: 2017-08-07 19:54 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.98 KB, patch)
2017-08-07 16:23 PDT, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-08-07 16:22:35 PDT 
Avoid a hash lookup in FilterInfo::remove()
Comment 1 Simon Fraser (smfr) 2017-08-07 16:23:30 PDT 
Created attachment 317493 [details]
Patch
Comment 2 Sam Weinig 2017-08-07 16:39:45 PDT 
Comment on attachment 317493 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317493&action=review

> Source/WebCore/rendering/RenderLayerFilterInfo.cpp:75
>      if (map().remove(&layer))
>          layer.m_hasFilterInfo = false;

Do you need to check the return value still? Seems like it will always return true now.
Comment 3 Simon Fraser (smfr) 2017-08-07 19:54:03 PDT 
https://trac.webkit.org/r220380
Comment 4 Radar WebKit Bug Importer 2017-08-07 19:54:51 PDT 
<rdar://problem/33768183>