WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
175301
Avoid a hash lookup in FilterInfo::remove()
https://bugs.webkit.org/show_bug.cgi?id=175301
Summary
Avoid a hash lookup in FilterInfo::remove()
Simon Fraser (smfr)
Reported
2017-08-07 16:22:35 PDT
Avoid a hash lookup in FilterInfo::remove()
Attachments
Patch
(1.98 KB, patch)
2017-08-07 16:23 PDT
,
Simon Fraser (smfr)
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2017-08-07 16:23:30 PDT
Created
attachment 317493
[details]
Patch
Sam Weinig
Comment 2
2017-08-07 16:39:45 PDT
Comment on
attachment 317493
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=317493&action=review
> Source/WebCore/rendering/RenderLayerFilterInfo.cpp:75 > if (map().remove(&layer)) > layer.m_hasFilterInfo = false;
Do you need to check the return value still? Seems like it will always return true now.
Simon Fraser (smfr)
Comment 3
2017-08-07 19:54:03 PDT
https://trac.webkit.org/r220380
Radar WebKit Bug Importer
Comment 4
2017-08-07 19:54:51 PDT
<
rdar://problem/33768183
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug