Bug 175299 - Use bmalloc::freealign() when deallocating aligned memory blocks
Summary: Use bmalloc::freealign() when deallocating aligned memory blocks
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: bmalloc (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daewoong Jang
URL:
Keywords:
Depends on:
Blocks: 143310
  Show dependency tree / graph
 
Reported: 2017-08-07 16:17 PDT by Daewoong Jang
Modified: 2017-08-08 16:05 PDT (History)
6 users (show)

See Also:

Attachments
patch (7.93 KB, patch)
2017-08-07 16:23 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
patch (8.38 KB, patch)
2017-08-07 16:37 PDT, Daewoong Jang 		no flags Details | Formatted Diff | Diff
patch (8.64 KB, patch)
2017-08-07 17:31 PDT, Daewoong Jang 		ggaren: review-
ggaren: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daewoong Jang 2017-08-07 16:17:14 PDT 
On windows, aligned memory block should be freed with _aligned_free(). For this case, this patch introduces new bmalloc API freealign().
Comment 1 Daewoong Jang 2017-08-07 16:23:05 PDT 
Created attachment 317492 [details]
patch
Comment 2 Daewoong Jang 2017-08-07 16:37:13 PDT 
Created attachment 317498 [details]
patch
Comment 3 Daewoong Jang 2017-08-07 17:31:34 PDT 
Created attachment 317521 [details]
patch
Comment 4 Geoffrey Garen 2017-08-08 09:33:18 PDT 
Comment on attachment 317521 [details]
patch

We don't use the DebugHeap on Windows.