Bug 175297 - Make TransformOperation::type() non-virtual
Summary: Make TransformOperation::type() non-virtual
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-07 15:29 PDT by Simon Fraser (smfr)
Modified: 2017-08-07 19:54 PDT (History)
7 users (show)

See Also:

Attachments
Patch (27.24 KB, patch)
2017-08-07 15:30 PDT, Simon Fraser (smfr) 		sam: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.32 MB, application/zip)
2017-08-07 17:35 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2017-08-07 15:29:40 PDT 
Make TransformOperation::type() non-virtual
Comment 1 Simon Fraser (smfr) 2017-08-07 15:30:20 PDT 
Created attachment 317483 [details]
Patch
Comment 2 Build Bot 2017-08-07 15:45:21 PDT 
Attachment 317483 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp:46:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/platform/graphics/transforms/ScaleTransformOperation.cpp:54:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Build Bot 2017-08-07 17:35:54 PDT 
Comment on attachment 317483 [details]
Patch

Attachment 317483 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4273038

New failing tests:
imported/w3c/web-platform-tests/IndexedDB/idbcursor-key.htm
Comment 4 Build Bot 2017-08-07 17:35:55 PDT 
Created attachment 317523 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 5 Simon Fraser (smfr) 2017-08-07 19:53:53 PDT 
https://trac.webkit.org/r220379
Comment 6 Radar WebKit Bug Importer 2017-08-07 19:54:46 PDT 
<rdar://problem/33768182>