Bug 175286 - check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
Summary: check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as fun...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-07 14:23 PDT by Yoshiaki Jitsukawa
Modified: 2017-08-07 16:26 PDT (History)
8 users (show)

See Also:

Attachments
Patch (3.73 KB, patch)
2017-08-07 14:39 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2017-08-07 14:23:06 PDT 
For example, the following code in Source/WebCore/platform/spi/cocoa/PassKitSPI.h causes
 a "Place brace on its own line for function definitions.  [whitespace/braces] [4]" error

typedef NS_ERROR_ENUM(PKPaymentErrorDomain, PKPaymentErrorCode) {
    PKPaymentUnknownError = -1,
...
Comment 1 Yoshiaki Jitsukawa 2017-08-07 14:30:36 PDT 
Moving platform/spi/cocoa/ into PAL will raise these kind of style errors so I'm fixing this in advance.
Comment 2 Yoshiaki Jitsukawa 2017-08-07 14:39:33 PDT 
Created attachment 317469 [details]
Patch
Comment 3 Yoshiaki Jitsukawa 2017-08-07 15:17:24 PDT 
Thank you for your reviewing!
Comment 4 WebKit Commit Bot 2017-08-07 16:25:31 PDT 
Comment on attachment 317469 [details]
Patch

Clearing flags on attachment: 317469

Committed r220367: <http://trac.webkit.org/changeset/220367>
Comment 5 WebKit Commit Bot 2017-08-07 16:25:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-08-07 16:26:12 PDT 
<rdar://problem/33764837>