Bug 175284 – Web Inspector: allow recordings to be saved via ⌘-S in the Recording tab

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Devin Rousso]

.

[Devin Rousso]

Created attachment 317461 [details]
Patch

[Matt Baker]

Comment on attachment 317461 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317461&action=review

r-, since this duplicates code in RecordingNavigationSidebarPanel. The sidebar should probably be using the new `saveData()` getter.

> Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:99
> +            forceSaveAs: true,

What are your thoughts on versioning?

[Devin Rousso]

(In reply to Matt Baker from comment #2)
> Comment on attachment 317461 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317461&action=review
> 
> r-, since this duplicates code in RecordingNavigationSidebarPanel. The
> sidebar should probably be using the new `saveData()` getter.
> 
> > Source/WebInspectorUI/UserInterface/Views/RecordingContentView.js:99
> > +            forceSaveAs: true,
> 
> What are your thoughts on versioning?
We already have a version in the Recording protocol.  I'm not sure what you mean otherwise.

[Devin Rousso]

Created attachment 318736 [details]
Patch

[Radar WebKit Bug Importer]

<rdar://problem/34040758>

[Matt Baker]

Comment on attachment 318736 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 318736 [details]
Patch

Clearing flags on attachment: 318736

Committed r222003: <http://trac.webkit.org/changeset/222003>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

Comment on attachment 318736 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318736&action=review

> Source/WebInspectorUI/UserInterface/Views/RecordingNavigationSidebarPanel.js:171
> +        WI.saveDataToFile(this.contentBrowser.currentContentView.saveData, forceSaveAs);

The saveData already has `forceSaveAs: true`. I suppose its fine to be explicit here, but this means that no matter what ContentView eventually shows up in the Recording tab will always be a forceSaveAs even if the ContentView logically can re-save. I don't think that ever be likely to happen though.