Bug 175274 - Web Inspector: create better icon for Canvas Path navigation item
Summary: Web Inspector: create better icon for Canvas Path navigation item
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Matt Baker
URL:
Keywords: InRadar
Depends on:
Blocks: WebInspectorCanvasTab 178432
  Show dependency tree / graph
 
Reported: 2017-08-07 11:23 PDT by Devin Rousso
Modified: 2017-12-04 17:32 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.69 KB, patch)
2017-08-17 13:44 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] Show path button (61.42 KB, image/png)
2017-08-17 13:48 PDT, Matt Baker 		no flags Details
Patch (2.68 KB, patch)
2017-08-17 18:21 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
[Image] Show path button - final (91.95 KB, image/png)
2017-08-17 18:22 PDT, Matt Baker 		no flags Details
Patch (2.68 KB, patch)
2017-08-17 19:31 PDT, Matt Baker 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2017-08-07 11:23:15 PDT 
Currently, we are using the PaintFlashing icon (paint brush), but that doesn't really convey the idea of a path very well.
Comment 1 Matt Baker 2017-08-17 13:44:45 PDT 
Created attachment 318413 [details]
Patch
Comment 2 Matt Baker 2017-08-17 13:48:47 PDT 
Created attachment 318414 [details]
[Image] Show path button

I like using the arc, it better conveys "path" than a straight line IMO.
Comment 3 Matt Baker 2017-08-17 18:21:27 PDT 
Created attachment 318453 [details]
Patch
Comment 4 Matt Baker 2017-08-17 18:22:30 PDT 
Created attachment 318454 [details]
[Image] Show path button - final

Changes based on feedback.
Comment 5 Joseph Pecoraro 2017-08-17 18:51:06 PDT 
Comment on attachment 318453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=318453&action=review

Please file a bug for Images/gtk. You may want to copy the PaintFlashing icon as Path.svg for gtk until they have a replacement. It would be bad to have a missing box icon.

> Source/WebInspectorUI/UserInterface/Images/Path.svg:6
> +    <path stroke="currentColor" fill="none" d="M 3 12 S 3 2 8 8 c 5.44 6.52 5-4 5-4"/>

This syntax is a little weird to me. I think the lowercase 'c' is important (relative curve). The "5-4" is this actually "5 -4"? If so a space might be helpful just for readability.
Comment 6 Matt Baker 2017-08-17 19:31:27 PDT 
Created attachment 318458 [details]
Patch
Comment 7 WebKit Commit Bot 2017-08-17 20:13:57 PDT 
Comment on attachment 318458 [details]
Patch

Clearing flags on attachment: 318458

Committed r220898: <http://trac.webkit.org/changeset/220898>
Comment 8 WebKit Commit Bot 2017-08-17 20:13:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-08-17 20:14:51 PDT 
<rdar://problem/33956146>