Bug 175271 – Resource Load Statistics: Clear web processes' state on history removal

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[John Wilander]

https://bugs.webkit.org/show_bug.cgi?id=175090 introduced state in the web process and that state needs to be cleared when the UI process' statistics are cleared as part of history removal.

[Radar WebKit Bug Importer]

<rdar://problem/33756560>

[John Wilander]

*** Bug 175266 has been marked as a duplicate of this bug. ***

[John Wilander]

Created attachment 317459 [details]
Patch

[Chris Dumez]

Comment on attachment 317459 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317459&action=review

> Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:379
> +        WTFLogAlways("ResourceLoadLog | About to call m_currentInvocation->didClearStatisticsThroughWebsiteDataRemoval().");

Should probably be removed.

> LayoutTests/http/tests/loading/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html:39
> +            testRunner.setStatisticsHasHadUserInteraction(topFrameOrigin, false);

Why is this here? Shouldn't clearing the data clear the user interaction too?

[John Wilander]

(In reply to Chris Dumez from comment #4)
> Comment on attachment 317459 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=317459&action=review
> 
> > Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:379
> > +        WTFLogAlways("ResourceLoadLog | About to call m_currentInvocation->didClearStatisticsThroughWebsiteDataRemoval().");
> 
> Should probably be removed.

Oops. Sure!

> > LayoutTests/http/tests/loading/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html:39
> > +            testRunner.setStatisticsHasHadUserInteraction(topFrameOrigin, false);
> 
> Why is this here? Shouldn't clearing the data clear the user interaction too?

True. I can remove it.

Rest is good?

[Chris Dumez]

Comment on attachment 317459 [details]
Patch

r=me if the test still passes after you drop the extra testRunner.setStatisticsHasHadUserInteraction() call.

[John Wilander]

(In reply to Chris Dumez from comment #6)
> Comment on attachment 317459 [details]
> Patch
> 
> r=me if the test still passes after you drop the extra
> testRunner.setStatisticsHasHadUserInteraction() call.

It does. Thanks!

[John Wilander]

Created attachment 317513 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 317513 [details]
Patch for landing

Clearing flags on attachment: 317513

Committed r220412: <http://trac.webkit.org/changeset/220412>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.