Bug 175252 - Analysis task page shows an empty results for an irrelevant top-level test
Summary: Analysis task page shows an empty results for an irrelevant top-level test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-06 17:10 PDT by Ryosuke Niwa
Modified: 2017-09-27 12:49 PDT (History)
9 users (show)

See Also:


Attachments
Fixes the bug (4.45 KB, patch)
2017-08-06 17:17 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Rebased for trunk (4.28 KB, patch)
2017-09-10 18:08 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-08-06 17:10:31 PDT
When there are multiple tests being tested in a single analysis task for perf try bots,
the test group results reviewer lists every test ever listed in the analysis task for every test group.
Comment 1 Ryosuke Niwa 2017-08-06 17:17:57 PDT
Created attachment 317388 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2017-09-10 18:08:21 PDT
Created attachment 320410 [details]
Rebased for trunk
Comment 3 Ryosuke Niwa 2017-09-10 18:11:24 PDT
This patch fixes the bug that analysis task pages for perf try bots show enumerate the union of all top level tests tested instead of the one tested in a particular test group. e.g. if you tested Speedometer & JetStream on a single perf try bots page, then both test groups enumerate both Speedometer & JetStream despite of the fact each test group tested exactly one of them.
Comment 4 Antti Koivisto 2017-09-11 05:15:20 PDT
Comment on attachment 320410 [details]
Rebased for trunk

r=me
Comment 5 Ryosuke Niwa 2017-09-11 11:56:35 PDT
Comment on attachment 320410 [details]
Rebased for trunk

Thanks for the review.
Comment 6 WebKit Commit Bot 2017-09-11 12:26:03 PDT
Comment on attachment 320410 [details]
Rebased for trunk

Clearing flags on attachment: 320410

Committed r221871: <http://trac.webkit.org/changeset/221871>
Comment 7 WebKit Commit Bot 2017-09-11 12:26:05 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-09-27 12:49:54 PDT
<rdar://problem/34694096>