Bug 175241 - Add ServiceWorkerJob
Summary: Add ServiceWorkerJob
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-05 21:22 PDT by Brady Eidson
Modified: 2017-12-06 03:30 PST (History)
7 users (show)

See Also:


Attachments
Patch (57.18 KB, patch)
2017-08-09 16:57 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (57.14 KB, patch)
2017-08-09 20:18 PDT, Brady Eidson
thorton: review+
Details | Formatted Diff | Diff
Archive of layout-test-results from ews125 for ios-simulator-wk2 (982.24 KB, application/zip)
2017-08-09 22:03 PDT, Build Bot
no flags Details
Landing run (57.49 KB, patch)
2017-08-10 10:54 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Landing run (57.15 KB, patch)
2017-08-10 10:56 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-08-05 21:22:17 PDT
Add ServiceWorkerJob and job queue

This will also include scheduling the very first job - The "register" job
Comment 1 Brady Eidson 2017-08-09 16:24:03 PDT
To keep the patch small, I'll just be adding ServiceWorkerJob and using it for one immediate promise rejection.

We'll queue jobs in the next patch.
Comment 2 Brady Eidson 2017-08-09 16:57:12 PDT
Created attachment 317761 [details]
Patch
Comment 3 Brady Eidson 2017-08-09 20:18:23 PDT
Created attachment 317778 [details]
Patch
Comment 4 Build Bot 2017-08-09 22:03:18 PDT
Comment on attachment 317778 [details]
Patch

Attachment 317778 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4287820

New failing tests:
fast/dom/insertedIntoDocument-sibling.html
Comment 5 Build Bot 2017-08-09 22:03:19 PDT
Created attachment 317783 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 6 Brady Eidson 2017-08-09 22:45:29 PDT
(In reply to Build Bot from comment #5)
> Created attachment 317783 [details]
> Archive of layout-test-results from ews125 for ios-simulator-wk2
> 
> The attached test failures were seen while running run-webkit-tests on the
> ios-sim-ews.
> Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

The crashing test is definitely not the result of this patch.
Comment 7 Tim Horton 2017-08-10 10:46:29 PDT
Comment on attachment 317778 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317778&action=review

> Source/WebCore/workers/ServiceWorkerJob.cpp:48
> +#ifndef NDEBUG

You shouldn't need these.

> Source/WebCore/workers/ServiceWorkerJob.cpp:55
> +#ifndef NDEBUG

You shouldn't need these.

> Source/WebCore/workers/ServiceWorkerJob.h:64
> +#ifndef NDEBUG

ASSERT_DISABLED
Comment 8 Brady Eidson 2017-08-10 10:54:08 PDT
Created attachment 317822 [details]
Landing run
Comment 9 Brady Eidson 2017-08-10 10:56:58 PDT
Created attachment 317823 [details]
Landing run
Comment 10 WebKit Commit Bot 2017-08-10 12:28:30 PDT
Comment on attachment 317823 [details]
Landing run

Clearing flags on attachment: 317823

Committed r220539: <http://trac.webkit.org/changeset/220539>