RESOLVED FIXED 175215
Have navigator.serviceWorker() actually return a ServiceWorkerContainer object
https://bugs.webkit.org/show_bug.cgi?id=175215
Summary Have navigator.serviceWorker() actually return a ServiceWorkerContainer object
Brady Eidson
Reported 2017-08-04 15:24:25 PDT
Have navigator.serviceWorker() actually return a ServiceWorkerContainer object
Attachments
Patch (39.74 KB, patch)
2017-08-04 15:28 PDT, Brady Eidson
no flags
Archive of layout-test-results from ews102 for mac-elcapitan (1.62 MB, application/zip)
2017-08-04 16:41 PDT, Build Bot
no flags
Archive of layout-test-results from ews113 for mac-elcapitan (1.76 MB, application/zip)
2017-08-04 17:10 PDT, Build Bot
no flags
Archive of layout-test-results from ews122 for ios-simulator-wk2 (1.18 MB, application/zip)
2017-08-04 17:28 PDT, Build Bot
no flags
Patch (41.26 KB, patch)
2017-08-04 19:15 PDT, Brady Eidson
buildbot: commit-queue-
Archive of layout-test-results from ews103 for mac-elcapitan (1005.50 KB, application/zip)
2017-08-04 20:16 PDT, Build Bot
no flags
Archive of layout-test-results from ews114 for mac-elcapitan (1.75 MB, application/zip)
2017-08-04 20:37 PDT, Build Bot
no flags
Patch for EWS/Landing (38.91 KB, patch)
2017-08-04 20:45 PDT, Brady Eidson
no flags
Brady Eidson
Comment 1 2017-08-04 15:28:35 PDT
youenn fablet
Comment 2 2017-08-04 15:36:39 PDT
Comment on attachment 317303 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317303&action=review > Source/WebCore/workers/ServiceWorkerContainer.cpp:66 > + rejectLater(WTFMove(promise), "ready"); It seems unnecessary to reject later, why not doing it now?
Brady Eidson
Comment 3 2017-08-04 15:55:00 PDT
(In reply to youenn fablet from comment #2) > Comment on attachment 317303 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=317303&action=review > > > Source/WebCore/workers/ServiceWorkerContainer.cpp:66 > > + rejectLater(WTFMove(promise), "ready"); > > It seems unnecessary to reject later, why not doing it now? My experience with promises in our bindings is minimal - Do we definitely properly handle synchronous responses to promises in all cases? I assumed the answer is "no" so I didn't go that route. I'm not particularly concerned about this as this is true early scaffolding code. It will go away shortly!
youenn fablet
Comment 4 2017-08-04 15:57:36 PDT
> My experience with promises in our bindings is minimal - Do we definitely > properly handle synchronous responses to promises in all cases? Yes, this is correctly handled.
Build Bot
Comment 5 2017-08-04 16:41:21 PDT
Comment on attachment 317303 [details] Patch Attachment 317303 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4255811 New failing tests: imported/w3c/web-platform-tests/FileAPI/historical.https.html
Build Bot
Comment 6 2017-08-04 16:41:22 PDT
Created attachment 317308 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 7 2017-08-04 17:10:24 PDT
Comment on attachment 317303 [details] Patch Attachment 317303 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4255854 New failing tests: imported/w3c/web-platform-tests/FileAPI/historical.https.html
Build Bot
Comment 8 2017-08-04 17:10:25 PDT
Created attachment 317316 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Build Bot
Comment 9 2017-08-04 17:28:32 PDT
Comment on attachment 317303 [details] Patch Attachment 317303 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/4255925 New failing tests: http/tests/security/cross-origin-indexeddb.html
Build Bot
Comment 10 2017-08-04 17:28:34 PDT
Created attachment 317317 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Brady Eidson
Comment 11 2017-08-04 19:08:54 PDT
(In reply to Build Bot from comment #9) > > Attachment 317303 [details] did not pass ios-sim-ews (ios-simulator-wk2): > > New failing tests: > http/tests/security/cross-origin-indexeddb.html Not caused by this.
Brady Eidson
Comment 12 2017-08-04 19:09:08 PDT
(In reply to Build Bot from comment #7) > Comment on attachment 317303 [details] > Patch > > Attachment 317303 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/4255854 > > New failing tests: > imported/w3c/web-platform-tests/FileAPI/historical.https.html This one probably is! Looking...
Brady Eidson
Comment 13 2017-08-04 19:12:47 PDT
(In reply to Brady Eidson from comment #12) > (In reply to Build Bot from comment #7) > > Comment on attachment 317303 [details] > > Patch > > > > Attachment 317303 [details] did not pass mac-debug-ews (mac): > > Output: http://webkit-queues.webkit.org/results/4255854 > > > > New failing tests: > > imported/w3c/web-platform-tests/FileAPI/historical.https.html > > This one probably is! Looking... Yup, WK1 results needed.
Brady Eidson
Comment 14 2017-08-04 19:15:04 PDT
Build Bot
Comment 15 2017-08-04 20:16:45 PDT
Comment on attachment 317322 [details] Patch Attachment 317322 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4256709 New failing tests: imported/w3c/web-platform-tests/FileAPI/historical.https.html
Build Bot
Comment 16 2017-08-04 20:16:47 PDT
Created attachment 317324 [details] Archive of layout-test-results from ews103 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-elcapitan Platform: Mac OS X 10.11.6
youenn fablet
Comment 17 2017-08-04 20:24:36 PDT
Since you might need to reupload a new patch, could you remove the rejectLater thing at the same time?
Build Bot
Comment 18 2017-08-04 20:37:24 PDT
Comment on attachment 317322 [details] Patch Attachment 317322 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4256723 New failing tests: imported/w3c/web-platform-tests/FileAPI/historical.https.html
Build Bot
Comment 19 2017-08-04 20:37:26 PDT
Created attachment 317325 [details] Archive of layout-test-results from ews114 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews114 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Brady Eidson
Comment 20 2017-08-04 20:45:54 PDT
Created attachment 317326 [details] Patch for EWS/Landing
Brady Eidson
Comment 21 2017-08-04 20:46:28 PDT
(In reply to Brady Eidson from comment #20) > Created attachment 317326 [details] > Patch for EWS/Landing Will CQ+ once EWS says 👍
WebKit Commit Bot
Comment 22 2017-08-04 21:59:52 PDT
Comment on attachment 317326 [details] Patch for EWS/Landing Clearing flags on attachment: 317326 Committed r220310: <http://trac.webkit.org/changeset/220310>
WebKit Commit Bot
Comment 23 2017-08-04 21:59:53 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 24 2017-08-04 22:00:42 PDT
Brady Eidson
Comment 25 2017-08-04 22:04:18 PDT
(In reply to youenn fablet from comment #17) > Since you might need to reupload a new patch, could you remove the > rejectLater thing at the same time? Ugh, sorry missed this in the middle of the layout test failure messages. As mentioned, they're not long for this world. Be gone soon.
Note You need to log in before you can comment on or make changes to this bug.