Bug 175214 - Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 2].
Summary: Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 2].
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 175144
  Show dependency treegraph
 
Reported: 2017-08-04 15:07 PDT by Mark Lam
Modified: 2017-08-04 17:05 PDT (History)
3 users (show)

See Also:


Attachments
proposed patch. (105.30 KB, patch)
2017-08-04 16:51 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (105.38 KB, patch)
2017-08-04 16:52 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch: fixed style issue. (105.55 KB, patch)
2017-08-04 16:59 PDT, Mark Lam
msaboff: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-08-04 15:07:29 PDT
Actually move the 64-bit and common DFGOSRExit code (previously in DFGOSRExitCompiler) into DFGOSRExit.cpp, and delete unneeded files.
Comment 1 Radar WebKit Bug Importer 2017-08-04 15:08:17 PDT
<rdar://problem/33733302>
Comment 2 Radar WebKit Bug Importer 2017-08-04 15:08:19 PDT
<rdar://problem/33733308>
Comment 3 Mark Lam 2017-08-04 16:51:02 PDT
Created attachment 317312 [details]
proposed patch.
Comment 4 Build Bot 2017-08-04 16:51:59 PDT
Attachment 317312 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGOSRExit32_64.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Mark Lam 2017-08-04 16:52:57 PDT
Created attachment 317313 [details]
proposed patch.
Comment 6 Build Bot 2017-08-04 16:54:51 PDT
Attachment 317313 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGOSRExit32_64.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Mark Lam 2017-08-04 16:59:24 PDT
Created attachment 317315 [details]
proposed patch: fixed style issue.
Comment 8 Michael Saboff 2017-08-04 17:02:07 PDT
Comment on attachment 317315 [details]
proposed patch: fixed style issue.

rs=me
Comment 9 Mark Lam 2017-08-04 17:05:24 PDT
Thanks for the review.  Landed in r220306: <http://trac.webkit.org/r220306>.