Bug 175208 - Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 1].
Summary: Move DFG::OSRExitCompiler methods into DFG::OSRExit [step 1].
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 175144
  Show dependency treegraph
 
Reported: 2017-08-04 14:17 PDT by Mark Lam
Modified: 2017-08-04 15:04 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch. (40.25 KB, patch)
2017-08-04 14:30 PDT, Mark Lam
no flags Details | Formatted Diff | Diff
proposed patch. (40.31 KB, patch)
2017-08-04 14:40 PDT, Mark Lam
saam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2017-08-04 14:17:01 PDT
This will minimize the code diff and make it easier to review the patch for https://bugs.webkit.org/show_bug.cgi?id=175144 later.  We'll do this patch in 3 steps:
1. Do the code changes to move methods into OSRExit.
2. Unify the 32-bit and 64-bit implementations of compileExit().
3. A follow up patch to actually copy the methods into DFGOSRExit.cpp, and delete the DFGOSRExitCompiler files.

Splitting this refactoring into these 3 steps also makes it easier to review this patch and understand what is being changed.
Comment 1 Mark Lam 2017-08-04 14:30:05 PDT
Created attachment 317289 [details]
proposed patch.
Comment 2 Mark Lam 2017-08-04 14:35:23 PDT
(In reply to Mark Lam from comment #0)
> 1. Do the code changes to move methods into OSRExit.
> 2. Unify the 32-bit and 64-bit implementations of compileExit().
> 3. A follow up patch to actually copy the methods into DFGOSRExit.cpp, and
> delete the DFGOSRExitCompiler files.

Let's change that.  I'll do this in the following steps instead:
1. Do the code changes to move methods into OSRExit.
2. Copy the 64-bit and common methods into DFGOSRExit.cpp, and delete the unused DFGOSRExitCompiler files.
3. Merge the 32-bit OSRExitCompiler methods into the 64-bit version, and delete DFGOSRExitCompiler32_64.cpp.

I think it's easier (and less error prone) to execute the refactoring this way.
Comment 3 Radar WebKit Bug Importer 2017-08-04 14:35:41 PDT
<rdar://problem/33732402>
Comment 4 Mark Lam 2017-08-04 14:40:51 PDT
Created attachment 317292 [details]
proposed patch.
Comment 5 Saam Barati 2017-08-04 15:00:10 PDT
Comment on attachment 317292 [details]
proposed patch.

r=me
Comment 6 Mark Lam 2017-08-04 15:04:31 PDT
Thanks for the review.  Landed in r220298: <http://trac.webkit.org/r220298>.