Bug 175205 - [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default
Summary: [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default
Status: RESOLVED DUPLICATE of bug 175207
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords:
Depends on:
Blocks: 175207
  Show dependency tree / graph
 
Reported: 2017-08-04 13:35 PDT by BJ Burg
Modified: 2017-08-07 08:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.36 KB, patch)
2017-08-04 13:37 PDT, BJ Burg 		cgarcia: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-08-04 13:35:41 PDT 
This was introduced to CMake here, turned off by default: https://trac.webkit.org/changeset/170964/webkit

It's enabled everywhere else. Let's turn it on so I can remove another pointless compile flag.
Comment 1 BJ Burg 2017-08-04 13:37:35 PDT 
Created attachment 317276 [details]
Patch
Comment 2 Carlos Garcia Campos 2017-08-05 00:23:32 PDT 
Comment on attachment 317276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317276&action=review

> Source/cmake/OptionsGTK.cmake:155
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE OFF)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE ON)

I have no idea why we have OFF here. Since the default is ON, we can probably remove the line, but you are going to remove the build gflag eventually, so it doesn't really matter.

> ChangeLog:3
> +        [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default

This doesn't change WPE
Comment 3 Michael Catanzaro 2017-08-05 12:23:39 PDT 
Yes, just remove it from OptionsGTK.cmake.
Comment 4 BJ Burg 2017-08-07 08:59:18 PDT 
(In reply to Michael Catanzaro from comment #3)
> Yes, just remove it from OptionsGTK.cmake.

Ok, I'll just mark this patch invalid and land 175207 (removes the guard entirely)
Comment 5 BJ Burg 2017-08-07 08:59:31 PDT 

*** This bug has been marked as a duplicate of bug 175207 ***