Bug 175205 – [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: WebKitGTK

[Blaze Burg]

This was introduced to CMake here, turned off by default: https://trac.webkit.org/changeset/170964/webkit

It's enabled everywhere else. Let's turn it on so I can remove another pointless compile flag.

[Blaze Burg]

Created attachment 317276 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 317276 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317276&action=review

> Source/cmake/OptionsGTK.cmake:155
> -WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE OFF)
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CANVAS_PATH PRIVATE ON)

I have no idea why we have OFF here. Since the default is ON, we can probably remove the line, but you are going to remove the build gflag eventually, so it doesn't really matter.

> ChangeLog:3
> +        [GTK][WPE] Turn on ENABLE_CANVAS_PATH by default

This doesn't change WPE

[Michael Catanzaro]

Yes, just remove it from OptionsGTK.cmake.

[Blaze Burg]

(In reply to Michael Catanzaro from comment #3)
> Yes, just remove it from OptionsGTK.cmake.

Ok, I'll just mark this patch invalid and land 175207 (removes the guard entirely)

[Blaze Burg]

*** This bug has been marked as a duplicate of bug 175207 ***