Bug 175194 - LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
Summary: LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-04 10:04 PDT by Ryan Haddad
Modified: 2017-08-09 15:37 PDT (History)
11 users (show)

See Also:


Attachments
patch (2.33 KB, patch)
2017-08-09 13:52 PDT, Nan Wang
cfleizach: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Ryan Haddad 2017-08-04 10:06:14 PDT
This test was added with https://trac.webkit.org/changeset/219075/webkit
Comment 2 Ryan Haddad 2017-08-04 10:07:36 PDT
--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/accessibility/presentation-role-iframe-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/accessibility/presentation-role-iframe-actual.txt
@@ -8,10 +8,10 @@
 
 1. Content child: AXRole: AXGroup
 1. Content grand child: AXRole: AXButton
+3. Content child: AXRole: AXGroup
+3. Content grand child: AXRole: AXButton
 2. Content child: AXRole: AXScrollArea
 2. Content grand child: AXRole: AXWebArea
-3. Content child: AXRole: AXGroup
-3. Content grand child: AXRole: AXButton
 PASS successfullyParsed is true
 
 TEST COMPLETE
Comment 3 Ryan Haddad 2017-08-04 10:08:00 PDT
Chris, it looks like this test has been flaky since it was added. Could you take a look?
Comment 4 chris fleizach 2017-08-04 18:05:43 PDT
(In reply to Ryan Haddad from comment #3)
> Chris, it looks like this test has been flaky since it was added. Could you
> take a look?

Yep, will do.
Comment 5 Nan Wang 2017-08-09 13:52:48 PDT
Created attachment 317735 [details]
patch
Comment 6 chris fleizach 2017-08-09 15:24:26 PDT
Comment on attachment 317735 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317735&action=review

r+ with style change

> LayoutTests/accessibility/presentation-role-iframe.html:33
> +var test1Log, test2Log, test3Log

semi-colon at the end?
also I think WebKit likes to put each variable on a separate line.

> LayoutTests/accessibility/presentation-role-iframe.html:62
> +    var result =  testNumber + ". Content child: " + content.childAtIndex(0).role;

extra space after =
Comment 7 Nan Wang 2017-08-09 15:36:06 PDT
Committed r220486: <http://trac.webkit.org/changeset/220486>
Comment 8 Radar WebKit Bug Importer 2017-08-09 15:37:32 PDT
<rdar://problem/33813333>