Bug 175194 – LayoutTest accessibility/presentation-role-iframe.html is a flaky failure

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ryan Haddad]

LayoutTest accessibility/presentation-role-iframe.html is a flaky failure

https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK1%20(Tests)/r220267%20(2810)/results.html

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=accessibility%2Fpresentation-role-iframe.html

[Ryan Haddad]

This test was added with https://trac.webkit.org/changeset/219075/webkit

[Ryan Haddad]

--- /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/accessibility/presentation-role-iframe-expected.txt
+++ /Volumes/Data/slave/elcapitan-debug-tests-wk1/build/layout-test-results/accessibility/presentation-role-iframe-actual.txt
@@ -8,10 +8,10 @@
 
 1. Content child: AXRole: AXGroup
 1. Content grand child: AXRole: AXButton
+3. Content child: AXRole: AXGroup
+3. Content grand child: AXRole: AXButton
 2. Content child: AXRole: AXScrollArea
 2. Content grand child: AXRole: AXWebArea
-3. Content child: AXRole: AXGroup
-3. Content grand child: AXRole: AXButton
 PASS successfullyParsed is true
 
 TEST COMPLETE

[Ryan Haddad]

Chris, it looks like this test has been flaky since it was added. Could you take a look?

[chris fleizach]

(In reply to Ryan Haddad from comment #3)
> Chris, it looks like this test has been flaky since it was added. Could you
> take a look?

Yep, will do.

[Nan Wang]

Created attachment 317735 [details]
patch

[chris fleizach]

Comment on attachment 317735 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317735&action=review

r+ with style change

> LayoutTests/accessibility/presentation-role-iframe.html:33
> +var test1Log, test2Log, test3Log

semi-colon at the end?
also I think WebKit likes to put each variable on a separate line.

> LayoutTests/accessibility/presentation-role-iframe.html:62
> +    var result =  testNumber + ". Content child: " + content.childAtIndex(0).role;

extra space after =

[Nan Wang]

Committed r220486: <http://trac.webkit.org/changeset/220486>

[Radar WebKit Bug Importer]

<rdar://problem/33813333>