Bug 175183 - WebDriver: Implement page load strategy
Summary: WebDriver: Implement page load strategy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 174618
Blocks: gtk-webdriver
  Show dependency tree / graph
 
Reported: 2017-08-04 03:54 PDT by Carlos Garcia Campos
Modified: 2017-08-05 04:15 PDT (History)
3 users (show)

See Also:

Attachments
Patch (30.37 KB, patch)
2017-08-04 06:04 PDT, Carlos Garcia Campos 		bburg: review+
Details | Formatted Diff | Diff
Patch for landing (30.05 KB, patch)
2017-08-05 02:50 PDT, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Carlos Garcia Campos 2017-08-04 06:04:22 PDT 
Created attachment 317239 [details]
Patch
Comment 2 Blaze Burg 2017-08-04 11:12:52 PDT 
Comment on attachment 317239 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317239&action=review

r=me, great work. Please send through EWS before landing.

> Source/WebKit/ChangeLog:8
> +        Split pending navigation maps into normal and eager, and one or the other depending on the received page load strategy.

Nit: ... and *use* one or the other ...

You don't actually say why two maps are needed here.

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:459
> +static void finishPendingNavigationsWithTimeoutFailure(HashMap<uint64_t, RefPtr<Inspector::BackendDispatcher::CallbackBase>>& map)

Nit: I prefer a name like "respondToPendingNavigationCallbacksWithTimeout" or something.

> Source/WebKit/UIProcess/Automation/WebAutomationSession.cpp:519
> +    Inspector::Protocol::Automation::PageLoadStrategy pageLoadStrategy = defaultPageLoadStrategy;

Okay, we have this same code three times. Can you extract it?
Comment 3 Carlos Garcia Campos 2017-08-05 02:50:23 PDT 
Created attachment 317334 [details]
Patch for landing
Comment 4 Carlos Garcia Campos 2017-08-05 04:14:44 PDT 
Committed r220317: <http://trac.webkit.org/changeset/220317>
Comment 5 Radar WebKit Bug Importer 2017-08-05 04:15:56 PDT 
<rdar://problem/33740067>