Related ticket: Bug 175057 - [PAL] Move spi/cf directory into PAL
This is to move platform/spi/cocoa to PAL.
Created attachment 317527 [details]
Created attachment 317556 [details]
There's interdependency between spi/cocoa and spi/cg so these two need to be moved at once.
Created attachment 317610 [details]
Created attachment 317637 [details]
Created attachment 317640 [details]
Comment on attachment 317640 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=317640&action=review
I'm not an OWNER of the WebKit subproject, but just the change in pathnames shouldn't require an OWNER. Other than the style for the "*" character, this looks good.
> +@property (nonatomic, readonly) AVPictureInPicturePlayerLayerView* pictureInPicturePlayerLayerView;
Unfortunately, this is actually backwards. The style is:
For C and C++ types:
For Objective-C types:
(In reply to Myles C. Maxfield from comment #7)
Thank you! I'll fix the style for Objective-C.
Created attachment 317774 [details]
Comment on attachment 317774 [details]
Clearing flags on attachment: 317774
Committed r220506: <http://trac.webkit.org/changeset/220506>
All reviewed patches have been landed. Closing bug.