Bug 175175 – [PAL] Move spi/cocoa and spi/cg directories into PAL

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Yoshiaki Jitsukawa]

Related ticket: Bug 175057 - [PAL] Move spi/cf directory into PAL

This is to move platform/spi/cocoa to PAL.

[Yoshiaki Jitsukawa]

Created attachment 317527 [details]
Patch

[Yoshiaki Jitsukawa]

Created attachment 317556 [details]
Patch

[Yoshiaki Jitsukawa]

There's interdependency between spi/cocoa and spi/cg so these two need to be moved at once.

[Yoshiaki Jitsukawa]

Created attachment 317610 [details]
Patch

[Yoshiaki Jitsukawa]

Created attachment 317637 [details]
Patch

[Yoshiaki Jitsukawa]

Created attachment 317640 [details]
Patch

[Myles C. Maxfield]

Comment on attachment 317640 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317640&action=review

I'm not an OWNER of the WebKit subproject, but just the change in pathnames shouldn't require an OWNER. Other than the style for the "*" character, this looks good.

> Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.hSource/WebCore/platform/spi/cocoa/AVKitSPI.h:74
> +@property (nonatomic, readonly) AVPictureInPicturePlayerLayerView* pictureInPicturePlayerLayerView;

Unfortunately, this is actually backwards. The style is:

For C and C++ types:
Type* foo;

For Objective-C types:
Type *foo;

[Yoshiaki Jitsukawa]

(In reply to Myles C. Maxfield from comment #7)
Thank you! I'll fix the style for Objective-C.

[Yoshiaki Jitsukawa]

Created attachment 317774 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 317774 [details]
Patch

Clearing flags on attachment: 317774

Committed r220506: <http://trac.webkit.org/changeset/220506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33820041>