Bug 175173 - [Cleanup] Remove ScriptGlobalObject
Summary: [Cleanup] Remove ScriptGlobalObject
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-03 19:28 PDT by Sam Weinig
Modified: 2017-08-04 11:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (19.70 KB, patch)
2017-08-03 19:40 PDT, Sam Weinig 		darin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-08-03 19:28:39 PDT 
[Cleanup] Remove ScriptGlobalObject
Comment 1 Sam Weinig 2017-08-03 19:40:16 PDT 
Created attachment 317203 [details]
Patch
Comment 2 Darin Adler 2017-08-03 21:09:08 PDT 
Comment on attachment 317203 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317203&action=review

> Source/WebCore/inspector/InspectorFrontendHost.cpp:388
> +    ASSERT(value && value.isObject());

Normally we would do this as two separate assertions so if one fails we know which one.

> Source/WebCore/inspector/InspectorFrontendHost.cpp:389
> +    auto* frontendApiObject = asObject(value);

Strange capitalization of API here.
Comment 3 Sam Weinig 2017-08-04 10:59:57 PDT 
Committed r220278: <http://trac.webkit.org/changeset/220278>
Comment 4 Radar WebKit Bug Importer 2017-08-04 11:01:04 PDT 
<rdar://problem/33727848>