RESOLVED FIXED 175173
[Cleanup] Remove ScriptGlobalObject 
https://bugs.webkit.org/show_bug.cgi?id=175173
Summary [Cleanup] Remove ScriptGlobalObject
Sam Weinig
Reported 2017-08-03 19:28:39 PDT
[Cleanup] Remove ScriptGlobalObject
Attachments
Patch (19.70 KB, patch)
2017-08-03 19:40 PDT, Sam Weinig 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2017-08-03 19:40:16 PDT
Created attachment 317203 [details] Patch
Darin Adler
Comment 2 2017-08-03 21:09:08 PDT
Comment on attachment 317203 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317203&action=review > Source/WebCore/inspector/InspectorFrontendHost.cpp:388 > + ASSERT(value && value.isObject()); Normally we would do this as two separate assertions so if one fails we know which one. > Source/WebCore/inspector/InspectorFrontendHost.cpp:389 > + auto* frontendApiObject = asObject(value); Strange capitalization of API here.
Sam Weinig
Comment 3 2017-08-04 10:59:57 PDT
Committed r220278: <http://trac.webkit.org/changeset/220278>
Radar WebKit Bug Importer
Comment 4 2017-08-04 11:01:04 PDT
<rdar://problem/33727848>
Note You need to log in before you can comment on or make changes to this bug.