Related ticket: Bug 175057 - [PAL] Move spi/cf directory into PAL This is to move other 13 SPI files in the cg, ios and win directories.
Created attachment 317785 [details] Patch
Created attachment 317798 [details] Patch
Created attachment 317800 [details] Patch
Created attachment 317813 [details] Patch
Created attachment 318184 [details] Patch
To WebKit OWNERS: Would you please review my patch? This patch moves files under WebCore/platform/spi/ios,win to PAL/pal/spi/, modifies WebCore/PAL Xcode projects and fixes coding style errors for it.
Comment on attachment 318184 [details] Patch Looks reasonable, rs=me
Comment on attachment 318184 [details] Patch Rejecting attachment 318184 [details] from commit-queue. Yoshiaki.Jitsukawa@sony.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.
Comment on attachment 318184 [details] Patch Rejecting attachment 318184 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 318184, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm patching file Source/WebKitLegacy/mac/WebView/WebView.mm patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/mac/EventSendingController.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4324366
Comment on attachment 318184 [details] Patch Rejecting attachment 318184 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 318184, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: g file Source/WebKitLegacy/mac/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebKitLegacy/mac/WebCoreSupport/WebFrameLoaderClient.mm patching file Source/WebKitLegacy/mac/WebView/WebView.mm patching file Tools/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Tools/DumpRenderTree/mac/EventSendingController.mm Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Antti Koivisto']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/4324392
Created attachment 318281 [details] Patch Updating the patch for the latest source tree.
Created attachment 318284 [details] Patch
Comment on attachment 318284 [details] Patch Clearing flags on attachment: 318284 Committed r220809: <http://trac.webkit.org/changeset/220809>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33927452>