Bug 175162 - [EME][Mac] SecureStop left on disk in Private Browsing mode.
Summary: [EME][Mac] SecureStop left on disk in Private Browsing mode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-03 15:44 PDT by Jer Noble
Modified: 2017-08-03 18:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.84 KB, patch)
2017-08-03 15:47 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Patch for landing (9.82 KB, patch)
2017-08-03 17:32 PDT, Jer Noble 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2017-08-03 15:44:13 PDT 
[EME][Mac] SecureStop left on disk in Private Browsing mode.
Comment 1 Jer Noble 2017-08-03 15:47:33 PDT 
Created attachment 317169 [details]
Patch
Comment 2 Jer Noble 2017-08-03 16:15:32 PDT 
<rdar://problem/33663231>
Comment 3 Eric Carlson 2017-08-03 16:18:52 PDT 
Comment on attachment 317169 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317169&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:108
> +    return pathByAppendingComponent(m_client->mediaKeysStorageDirectory(), "SecureStop.plist");

Nit: you can use “storageDirectory” here
Comment 4 Jer Noble 2017-08-03 17:32:42 PDT 
Created attachment 317185 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2017-08-03 18:13:10 PDT 
Comment on attachment 317185 [details]
Patch for landing

Clearing flags on attachment: 317185

Committed r220247: <http://trac.webkit.org/changeset/220247>
Comment 6 WebKit Commit Bot 2017-08-03 18:13:12 PDT 
All reviewed patches have been landed.  Closing bug.