Bug 175157 - Dashboard bubbles sometimes show failure count instead of crash count
Summary: Dashboard bubbles sometimes show failure count instead of crash count
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
Depends on:
Reported: 2017-08-03 15:00 PDT by Aakash Jain
Modified: 2017-08-04 13:01 PDT (History)
8 users (show)

See Also:

Proposed patch (1.76 KB, patch)
2017-08-03 15:05 PDT, Aakash Jain
ap: review+
Details | Formatted Diff | Diff
Patch for landing (1.76 KB, patch)
2017-08-04 11:55 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2017-08-03 15:00:57 PDT
See <rdar://problem/33709009>
Comment 1 Aakash Jain 2017-08-03 15:05:41 PDT
Created attachment 317163 [details]
Proposed patch
Comment 2 Aakash Jain 2017-08-03 17:41:05 PDT
This change wasn't required earlier, because with buildbot 0.8, testStep.results[1] used to be an array, but in buildbot 0.9, the same is replaced with state_string which is a string (equivalent to concatenated array).

Old Sample testStep.results[1]:
          "53 failures", 
          "37 new passes", 
          "1 crashes"

New sample state_string:
"53 failures 37 new passes 1 crashes"
Comment 3 Daniel Bates 2017-08-03 19:11:04 PDT
Can we write a unit test for this change?
Comment 4 Alexey Proskuryakov 2017-08-04 09:35:14 PDT
Comment on attachment 317163 [details]
Proposed patch

I think it's worth adding a comment explaining which two cases we support here, especially given that there is no regression test.
Comment 5 Aakash Jain 2017-08-04 11:55:04 PDT
Created attachment 317263 [details]
Patch for landing

Added a comment mentioning sample data. We only support the new format (buildbot 0.8 data is already converted to buildbot 0.9 format before reaching here).

Filed https://bugs.webkit.org/show_bug.cgi?id=175200 for adding unit tests.
Comment 6 WebKit Commit Bot 2017-08-04 13:01:19 PDT
Comment on attachment 317263 [details]
Patch for landing

Clearing flags on attachment: 317263

Committed r220287: <http://trac.webkit.org/changeset/220287>
Comment 7 WebKit Commit Bot 2017-08-04 13:01:21 PDT
All reviewed patches have been landed.  Closing bug.