Bug 175146 - Add tests for NeverDestroyed
Summary: Add tests for NeverDestroyed
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-08-03 12:00 PDT by Joseph Pecoraro
Modified: 2017-08-04 12:05 PDT (History)
6 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (81.83 KB, patch)
2017-08-03 12:05 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (81.82 KB, patch)
2017-08-03 12:08 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (82.95 KB, patch)
2017-08-03 13:07 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2017-08-03 12:00:15 PDT 
Add tests for NeverDestroyed.

Specifically to test the case changed with:
https://bugs.webkit.org/show_bug.cgi?id=175113
https://trac.webkit.org/changeset/220183/webkit
Comment 1 Joseph Pecoraro 2017-08-03 12:05:56 PDT 
Created attachment 317137 [details]
[PATCH] Proposed Fix

Is this what you guys were thinking? Any other specific tests you want me to add?

I considered a test of NeverDestroyed with a RefCounted objects (these cases trigger relaxAdoptionRequirement) but there are cases of this in other TestWebKitAPI tests and it seems this would be about assertions.
Comment 2 Build Bot 2017-08-03 12:08:20 PDT 
Attachment 317137 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:36:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:39:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:42:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:87:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:90:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:93:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:99:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 9 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Joseph Pecoraro 2017-08-03 12:08:26 PDT 
Created attachment 317138 [details]
[PATCH] Proposed Fix
Comment 4 Build Bot 2017-08-03 12:11:33 PDT 
Attachment 317138 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:29:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:36:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:39:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:42:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:87:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:90:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:93:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:99:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 9 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Joseph Pecoraro 2017-08-03 13:07:59 PDT 
Created attachment 317141 [details]
[PATCH] Proposed Fix
Comment 6 Build Bot 2017-08-03 13:09:40 PDT 
Attachment 317141 [details] did not pass style-queue:


ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:36:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:39:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:42:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:87:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:90:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:93:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:96:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Tools/TestWebKitAPI/Tests/WTF/LifecycleLogger.cpp:99:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 8 in 9 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2017-08-04 12:04:51 PDT 
Comment on attachment 317141 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 317141

Committed r220284: <http://trac.webkit.org/changeset/220284>
Comment 8 WebKit Commit Bot 2017-08-04 12:04:52 PDT 
All reviewed patches have been landed.  Closing bug.