WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
175142
Rename ScratchBuffer::activeLengthPtr to addressOfActiveLength.
https://bugs.webkit.org/show_bug.cgi?id=175142
Summary
Rename ScratchBuffer::activeLengthPtr to addressOfActiveLength.
Mark Lam
Reported
2017-08-03 11:25:14 PDT
The convention in the rest of of JSC for such methods which return the address of a field is to name them "addressOf<field name>". We'll rename ScratchBuffer::activeLengthPtr to be consistent with this convention.
Attachments
proposed patch.
(13.87 KB, patch)
2017-08-03 11:31 PDT
,
Mark Lam
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2017-08-03 11:26:30 PDT
<
rdar://problem/33704528
>
Mark Lam
Comment 2
2017-08-03 11:31:48 PDT
Created
attachment 317132
[details]
proposed patch.
Mark Lam
Comment 3
2017-08-03 11:37:34 PDT
Comment on
attachment 317132
[details]
proposed patch. Thanks for the review.
WebKit Commit Bot
Comment 4
2017-08-03 12:17:17 PDT
Comment on
attachment 317132
[details]
proposed patch. Clearing flags on attachment: 317132 Committed
r220219
: <
http://trac.webkit.org/changeset/220219
>
WebKit Commit Bot
Comment 5
2017-08-03 12:17:18 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug