Bug 175140 - [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for the JSC tests.
Summary: [GTK][WKE] Pass the --memory-limited option on the GTK and WPE buildbots for ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-03 10:37 PDT by Carlos Alberto Lopez Perez
Modified: 2022-03-01 02:36 PST (History)
7 users (show)

See Also:


Attachments
Patch (2.09 KB, patch)
2017-08-03 11:21 PDT, Carlos Alberto Lopez Perez
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2017-08-03 10:37:46 PDT
We are having lately (not sure when this started, but as time goes is getting worse and worse) lots of issues with JSC tests causing OOM problems on the GTK+ and WPE bots. Sometimes even bringing the machines down requiring a hard reboot.

The machines have as much as RAM as the Mac bots. However meanwhile the Mac bots seem to handle this fine, Linux bots don't.

Follow the bugs on the see also list to read more details about this if you are interested.

The best thing we can do now is to workaround this by disabling all the tests marked as memoryLimited on the GTK and WPE bots.

We may revise this on the future when we understand better what causes this.
Comment 1 Carlos Alberto Lopez Perez 2017-08-03 11:21:30 PDT
Created attachment 317131 [details]
Patch
Comment 2 Aakash Jain 2017-08-03 11:25:05 PDT
looks fine to me.
Comment 3 Alexey Proskuryakov 2017-08-03 12:23:08 PDT
Comment on attachment 317131 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317131&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:338
> +        # Linux bots have problems with JSC tests that try to use large amounts of memory.

It would help to have a link to more information right here. It's of course possible to get back to the bug using svn blame, but having the link in the comment will save some time in the future.

The questions people will be asking are "Can I remove this now? What should I test to confirm whether I can?"
Comment 4 Carlos Alberto Lopez Perez 2017-08-03 12:37:22 PDT
Committed r220221: <http://trac.webkit.org/changeset/220221>
Comment 5 Radar WebKit Bug Importer 2017-08-03 12:38:27 PDT
<rdar://problem/33706286>