Bug 175129 - [EME] Push CDMFactory into the platform layer
Summary: [EME] Push CDMFactory into the platform layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zan Dobersek
URL:
Keywords: InRadar
Depends on:
Blocks: 175136
  Show dependency tree / graph
 
Reported: 2017-08-03 05:18 PDT by Zan Dobersek
Modified: 2017-08-04 02:56 PDT (History)
3 users (show)

See Also:

Attachments
WIP (17.61 KB, patch)
2017-08-03 05:21 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch (18.00 KB, patch)
2017-08-03 08:29 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Patch for landing (18.17 KB, patch)
2017-08-04 02:51 PDT, Zan Dobersek 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zan Dobersek 2017-08-03 05:18:46 PDT 
[EME] Push CDMFactory into the platform layer
Comment 1 Zan Dobersek 2017-08-03 05:21:03 PDT 
Created attachment 317115 [details]
WIP
Comment 2 Zan Dobersek 2017-08-03 08:29:16 PDT 
Created attachment 317122 [details]
Patch
Comment 3 Xabier Rodríguez Calvar 2017-08-04 02:07:27 PDT 
Comment on attachment 317122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317122&action=review

> Source/WebCore/platform/GStreamer.cmake:142
> +        platform/encryptedmedia/gstreamer/CDMFactoryGStreamer.cpp

It looks like this file should go under platform/graphics/gstreamer/eme/

> Source/WebCore/platform/encryptedmedia/CDMFactory.cpp:2
> + * Copyright (C) 2016 Apple Inc. All rights reserved.

It looks like Igalia can have some credit here.

> Source/WebCore/platform/encryptedmedia/CDMFactory.h:2
> + * Copyright (C) 2016 Apple Inc. All rights reserved.

Ditto

> Source/WebCore/platform/encryptedmedia/CDMFactory.h:49
> +    // CDMFactory objectes is queried for the first time.

typo
Comment 4 Zan Dobersek 2017-08-04 02:51:00 PDT 
Created attachment 317230 [details]
Patch for landing
Comment 5 Zan Dobersek 2017-08-04 02:54:45 PDT 
Comment on attachment 317230 [details]
Patch for landing

Clearing flags on attachment: 317230

Committed r220264: <http://trac.webkit.org/changeset/220264>
Comment 6 Zan Dobersek 2017-08-04 02:54:49 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Radar WebKit Bug Importer 2017-08-04 02:56:03 PDT 
<rdar://problem/33720760>