A TextStream operator<< implementation for LayoutUnit is currently defined within TextStream directly. The TextStream operator<< for LayoutUnit should be within LayoutUnit's definition. This dependency makes it harder to move TextStream to PAL and should be removed.
Created attachment 317071 [details] Patch
Comment on attachment 317071 [details] Patch Myles can I get a review? I can fix the xcode project so Mac builds tomorrow. After that I'll see if I can get TextStream into PAL.
Comment on attachment 317071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317071&action=review I think this is good but I won’t give it the formal review until the EWS bubbles are green. > Source/WebCore/platform/LayoutUnit.cpp:2 > + * Copyright (C) 2004, 2008, 2010 Apple Inc. All rights reserved. The dates and the company seem wrong
Comment on attachment 317071 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=317071&action=review >> Source/WebCore/platform/LayoutUnit.cpp:2 >> + * Copyright (C) 2004, 2008, 2010 Apple Inc. All rights reserved. > > The dates and the company seem wrong I guess you’re just moving code, so I guess they’re right.
Created attachment 317143 [details] Patch Rebased after sorting
Created attachment 317148 [details] Patch Hopefully fix xcode
Comment on attachment 317148 [details] Patch Clearing flags on attachment: 317148 Committed r220249: <http://trac.webkit.org/changeset/220249>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33715434>