Bug 175110 - Remove LayoutUnit dependency in TextStream
Summary: Remove LayoutUnit dependency in TextStream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-02 19:38 PDT by Don Olmstead
Modified: 2017-08-03 19:39 PDT (History)
5 users (show)

See Also:


Attachments
Patch (7.75 KB, patch)
2017-08-02 20:01 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (7.79 KB, patch)
2017-08-03 13:20 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff
Patch (9.42 KB, patch)
2017-08-03 13:52 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-08-02 19:38:12 PDT
A TextStream operator<< implementation for LayoutUnit is currently defined within TextStream directly. The TextStream operator<< for LayoutUnit should be within LayoutUnit's definition.

This dependency makes it harder to move TextStream to PAL and should be removed.
Comment 1 Don Olmstead 2017-08-02 20:01:36 PDT
Created attachment 317071 [details]
Patch
Comment 2 Don Olmstead 2017-08-02 20:25:16 PDT
Comment on attachment 317071 [details]
Patch

Myles can I get a review? I can fix the xcode project so Mac builds tomorrow. After that I'll see if I can get TextStream into PAL.
Comment 3 Myles C. Maxfield 2017-08-02 22:09:42 PDT
Comment on attachment 317071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317071&action=review

I think this is good but I won’t give it the formal review until the EWS bubbles are green.

> Source/WebCore/platform/LayoutUnit.cpp:2
> + * Copyright (C) 2004, 2008, 2010 Apple Inc. All rights reserved.

The dates and the company seem wrong
Comment 4 Myles C. Maxfield 2017-08-02 22:10:48 PDT
Comment on attachment 317071 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317071&action=review

>> Source/WebCore/platform/LayoutUnit.cpp:2
>> + * Copyright (C) 2004, 2008, 2010 Apple Inc. All rights reserved.
> 
> The dates and the company seem wrong

I guess you’re just moving code, so I guess they’re right.
Comment 5 Don Olmstead 2017-08-03 13:20:03 PDT
Created attachment 317143 [details]
Patch

Rebased after sorting
Comment 6 Don Olmstead 2017-08-03 13:52:18 PDT
Created attachment 317148 [details]
Patch

Hopefully fix xcode
Comment 7 WebKit Commit Bot 2017-08-03 19:37:56 PDT
Comment on attachment 317148 [details]
Patch

Clearing flags on attachment: 317148

Committed r220249: <http://trac.webkit.org/changeset/220249>
Comment 8 WebKit Commit Bot 2017-08-03 19:37:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 9 Radar WebKit Bug Importer 2017-08-03 19:39:00 PDT
<rdar://problem/33715434>