Bug 175109 - NetworkResourceLoader::setDefersLoading() may cause start() to be called multiple times
Summary: NetworkResourceLoader::setDefersLoading() may cause start() to be called mult...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-02 19:30 PDT by Chris Dumez
Modified: 2017-08-02 22:57 PDT (History)
8 users (show)

See Also:

Attachments
Patch (14.85 KB, patch)
2017-08-02 19:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.85 KB, patch)
2017-08-02 20:28 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2017-08-02 19:30:35 PDT 
NetworkResourceLoader::setDefersLoading() may cause start() to be called multiple times.
Comment 1 Chris Dumez 2017-08-02 19:30:52 PDT 
<rdar://problem/33363169>
Comment 2 Chris Dumez 2017-08-02 19:56:16 PDT 
Created attachment 317070 [details]
Patch
Comment 3 Brady Eidson 2017-08-02 20:12:27 PDT 
Comment on attachment 317070 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=317070&action=review

> Source/WebKit/ChangeLog:16
> +        Normally, setDefersLoading(false) returns without calling start() is m_networkLoad is not null. It

typo "...if m_networkLoad is not..."
Comment 4 Chris Dumez 2017-08-02 20:28:57 PDT 
Created attachment 317078 [details]
Patch
Comment 5 WebKit Commit Bot 2017-08-02 22:57:48 PDT 
Comment on attachment 317078 [details]
Patch

Clearing flags on attachment: 317078

Committed r220185: <http://trac.webkit.org/changeset/220185>
Comment 6 WebKit Commit Bot 2017-08-02 22:57:50 PDT 
All reviewed patches have been landed.  Closing bug.