REGRESSION(r220052): http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing.

[Matt Lewis]

Created attachment 317061 [details]
Crash Log

Crash In: com.apple.WebCore:WebCore::FrameLoader::checkLoadComplete() + 90 (FrameLoader.cpp:2502)


http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing on all debug testers according to the dashboard:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=http%2Ftests%2Fappcache%2Fdeferred-events-delete-while-raising-timer.html

This crash started after: https://trac.webkit.org/changeset/220052/webkit

Build:
https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r220159%20(2753)/results.html
https://build.webkit.org/builders/Apple%20Sierra%20Debug%20WK1%20(Tests)/builds/2753

[Matt Lewis]

Marked test as flaky for now:
https://trac.webkit.org/changeset/220174/webkit

[Darin Adler]

This is an incorrect assertion. The fix is to move the assertion down past the null check of "page".

[Darin Adler]

Unfortunately I don’t have time to make the fix before coming in for the day.

Someone else is welcome to fix it if you want a fix before I get to it.

[Darin Adler]

Created attachment 318124 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 318124 [details]
Patch

Clearing flags on attachment: 318124

Committed r220750: <http://trac.webkit.org/changeset/220750>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33899758>