Bug 175099 – [Fetch API] Response should keep all ResourceResponse information

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

This is useful if caching the response or reusing it from a service worker.

[youenn fablet]

Created attachment 317030 [details]
Patch

[Build Bot]

Comment on attachment 317030 [details]
Patch

Attachment 317030 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4242742

New failing tests:
http/tests/inspector/network/fetch-network-data.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html

[Build Bot]

Created attachment 317041 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[youenn fablet]

Created attachment 317044 [details]
Patch

[Build Bot]

Comment on attachment 317044 [details]
Patch

Attachment 317044 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/4243084

New failing tests:
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html

[Build Bot]

Created attachment 317057 [details]
Archive of layout-test-results from ews101 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 317044 [details]
Patch

Attachment 317044 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4243260

New failing tests:
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html

[Build Bot]

Created attachment 317063 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[youenn fablet]

Created attachment 317134 [details]
Patch

[Sam Weinig]

Is the goal to (eventually) add all the flags / state defined in https://fetch.spec.whatwg.org/#concept-response to ResourceResponse?

[youenn fablet]

(In reply to Sam Weinig from comment #10)
> Is the goal to (eventually) add all the flags / state defined in
> https://fetch.spec.whatwg.org/#concept-response to ResourceResponse?

This is roughly the direction but this is case-by-case really.
This tainting thing is a convenient way to support filtered response and internal response.
That will allow service worker to send opaque responses with all information.
Having the tainting/filtering information in ResourceResponse allows easy transfer of this information to different threads and different processes which is useful for Workers or Cache API.

[Sam Weinig]

(In reply to youenn fablet from comment #11)
> (In reply to Sam Weinig from comment #10)
> > Is the goal to (eventually) add all the flags / state defined in
> > https://fetch.spec.whatwg.org/#concept-response to ResourceResponse?
> 
> This is roughly the direction but this is case-by-case really.
> This tainting thing is a convenient way to support filtered response and
> internal response.
> That will allow service worker to send opaque responses with all information.
> Having the tainting/filtering information in ResourceResponse allows easy
> transfer of this information to different threads and different processes
> which is useful for Workers or Cache API.

Ok. It would be nice to have a clearer picture for where the load infrastructure is going, and how it will map to the Fetch standard.

[youenn fablet]

> Ok. It would be nice to have a clearer picture for where the load
> infrastructure is going, and how it will map to the Fetch standard.

CachedResourceRequest is the equivalent of a fetch request.
Cached resource is the equivalent of a fetch record/on-going fetch.
Fetch algorithm entry point is either CachedResourceLoader (like the refactored beacon API loading) or DocumentThreadableLoader/FetchLoader for raw resources.

Fetch algorithm is mainly implemented in CachedResourceLoader/CachedResource/ResourceLoader although part of it is in DocumentThreadableLoader also.

[WebKit Commit Bot]

Comment on attachment 317134 [details]
Patch

Clearing flags on attachment: 317134

Committed r220320: <http://trac.webkit.org/changeset/220320>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33742093>