Bug 175088 - [Cocoa] Web Automation: copy JavaScript atoms to WebKit.framework private headers
Summary: [Cocoa] Web Automation: copy JavaScript atoms to WebKit.framework private hea...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-02 14:29 PDT by BJ Burg
Modified: 2017-08-04 09:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (6.81 KB, patch)
2017-08-02 14:48 PDT, BJ Burg
joepeck: review+
bburg: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2017-08-02 14:29:02 PDT
To be used by safaridriver, like Automation.json.
Comment 1 BJ Burg 2017-08-02 14:44:55 PDT
<rdar://problem/33685818>
Comment 2 BJ Burg 2017-08-02 14:48:40 PDT
Created attachment 317003 [details]
Patch
Comment 3 Sam Weinig 2017-08-02 15:52:14 PDT
Seems really weird for .js files to be in PrivateHeaders. Why not Resources?
Comment 4 Joseph Pecoraro 2017-08-02 21:07:28 PDT
> Seems really weird for .js files to be in PrivateHeaders. Why not Resources?

We have perl and python files in WebCore's PrivateHeaders.

I think making these PrivateHeaders is because we will want to expose them or ingest them in another framework, but not actually make them be resources of WebKit.framework?
Comment 5 BJ Burg 2017-08-03 08:51:19 PDT
Sam and I discussed offline that private headers is how we usually share build-time resources between frameworks, due to internal build considerations. We could hypothetically put the atoms in WebKit.framework or WebDriver.framework bundle resources, but the current strategy uses xxd.pl to turn them into C++ files. So they are needed at build time not runtime.
Comment 6 Joseph Pecoraro 2017-08-03 16:30:53 PDT
Comment on attachment 317003 [details]
Patch

r=me
Comment 7 BJ Burg 2017-08-04 09:44:49 PDT
Committed r220275: <http://trac.webkit.org/changeset/220275>