Bug 175087 - [WebIDL] Simplify [EnabledBySettings] extended attribute code to not require passing a global object to finishCreation
Summary: [WebIDL] Simplify [EnabledBySettings] extended attribute code to not require ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-02 14:02 PDT by Sam Weinig
Modified: 2017-08-02 20:26 PDT (History)
5 users (show)

See Also:


Attachments
Patch (19.81 KB, patch)
2017-08-02 14:19 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (19.84 KB, patch)
2017-08-02 15:26 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Patch (19.87 KB, patch)
2017-08-02 15:43 PDT, Sam Weinig
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.39 MB, application/zip)
2017-08-02 17:55 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2017-08-02 14:02:01 PDT
[WebIDL] Simplify [EnabledBySettings] extended attribute code to not require passing a global object to finishCreation
Comment 1 Sam Weinig 2017-08-02 14:19:33 PDT
Created attachment 316994 [details]
Patch
Comment 2 Chris Dumez 2017-08-02 14:59:06 PDT
Red bubbles
Comment 3 Sam Weinig 2017-08-02 15:24:09 PDT Comment hidden (obsolete)
Comment 4 Sam Weinig 2017-08-02 15:26:35 PDT Comment hidden (obsolete)
Comment 5 Build Bot 2017-08-02 15:30:11 PDT Comment hidden (obsolete)
Comment 6 Sam Weinig 2017-08-02 15:43:03 PDT
Created attachment 317018 [details]
Patch
Comment 7 Build Bot 2017-08-02 17:55:05 PDT
Comment on attachment 317018 [details]
Patch

Attachment 317018 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4242885

New failing tests:
imported/blink/fast/dom/HTMLImageElement/image-sizes-viewport-with-template-parent.html
Comment 8 Build Bot 2017-08-02 17:55:06 PDT
Created attachment 317047 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 9 Sam Weinig 2017-08-02 19:39:51 PDT
Crash is unrelated.
Comment 10 Chris Dumez 2017-08-02 19:57:34 PDT
Comment on attachment 317018 [details]
Patch

r=me, thanks.
Comment 11 Chris Dumez 2017-08-02 20:00:00 PDT
Crash:
Thread 15 Crashed:: WTF::AutomaticThread
0   com.apple.JavaScriptCore      	0x000000010ba6f6a6 0x10b83c000 + 2307750
1   com.apple.JavaScriptCore      	0x000000010c2af998 WTF::AtomicStringImpl::add(unsigned char const*) + 88 (WTFThreadData.h:50)
2   com.apple.WebCore             	0x0000000109160265 WebCore::Settings::initializeDefaultFontFamilies() + 53 (utility:765)
3   com.apple.WebCore             	0x000000010915e760 WebCore::Settings::Settings(WebCore::Page*) + 720 (Settings.cpp:231)
4   com.apple.WebCore             	0x000000010915ea98 WebCore::Settings::create(WebCore::Page*) + 40 (Ref.h:144)
5   com.apple.WebCore             	0x0000000108460a29 WebCore::Document::Document(WebCore::Frame*, WebCore::URL const&, unsigned int, unsigned int) + 313 (Document.cpp:469)
6   com.apple.WebCore             	0x00000001086a6011 WebCore::HTMLDocument::HTMLDocument(WebCore::Frame*, WebCore::URL const&, unsigned char, unsigned int) + 17 (HTMLDocument.cpp:87)
7   com.apple.WebCore             	0x000000010847abd7 WebCore::Document::ensureTemplateDocument() + 135 (type_traits:3561)
8   com.apple.WebCore             	0x0000000108720dc3 WebCore::HTMLTemplateElement::content() const + 35 (HTMLTemplateElement.cpp:62)
9   com.apple.WebCore             	0x0000000108aae932 WebCore::JSHTMLTemplateElement::visitAdditionalChildren(JSC::SlotVisitor&) + 18 (Node.h:614)
10  com.apple.JavaScriptCore      	0x000000010c194af2 JSC::SlotVisitor::drain(WTF::MonotonicTime) + 578 (SlotVisitor.cpp:385)
11  com.apple.JavaScriptCore      	0x000000010c19514d JSC::SlotVisitor::drainFromShared(JSC::SlotVisitor::SharedDrainMode, WTF::MonotonicTime) + 61 (SlotVisitor.cpp:653)
12  com.apple.JavaScriptCore      	0x000000010bdba17b WTF::SharedTaskFunctor<void (), JSC::Heap::runBeginPhase(JSC::GCConductor)::$_11>::run() + 603 (SlotVisitor.h:258)
13  com.apple.JavaScriptCore      	0x000000010c2d339c WTF::ParallelHelperClient::runTask(WTF::RefPtr<WTF::SharedTask<void ()> >) + 44 (RefPtr.h:79)
14  com.apple.JavaScriptCore      	0x000000010c2d3f20 WTF::ParallelHelperPool::Thread::work() + 48 (utility:766)
15  com.apple.JavaScriptCore      	0x000000010c2b3950 WTF::Function<void ()>::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker const&)::$_0>::call() + 240 (AutomaticThread.cpp:223)
16  com.apple.JavaScriptCore      	0x000000010c2ead3f WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 175 (memory:2459)
17  com.apple.JavaScriptCore      	0x000000010c2ec369 WTF::wtfThreadEntryPoint(void*) + 9 (ThreadingPthreads.cpp:203)
18  libsystem_pthread.dylib       	0x00007fff92cab99d _pthread_body + 131
19  libsystem_pthread.dylib       	0x00007fff92cab91a _pthread_start + 168
20  libsystem_pthread.dylib       	0x00007fff92ca9351 thread_start + 13

This was likely caused by you though:
https://bugs.webkit.org/show_bug.cgi?id=175006
Comment 12 Sam Weinig 2017-08-02 20:01:01 PDT
(In reply to Chris Dumez from comment #11)
> Crash:
> Thread 15 Crashed:: WTF::AutomaticThread
> 0   com.apple.JavaScriptCore      	0x000000010ba6f6a6 0x10b83c000 + 2307750
> 1   com.apple.JavaScriptCore      	0x000000010c2af998
> WTF::AtomicStringImpl::add(unsigned char const*) + 88 (WTFThreadData.h:50)
> 2   com.apple.WebCore             	0x0000000109160265
> WebCore::Settings::initializeDefaultFontFamilies() + 53 (utility:765)
> 3   com.apple.WebCore             	0x000000010915e760
> WebCore::Settings::Settings(WebCore::Page*) + 720 (Settings.cpp:231)
> 4   com.apple.WebCore             	0x000000010915ea98
> WebCore::Settings::create(WebCore::Page*) + 40 (Ref.h:144)
> 5   com.apple.WebCore             	0x0000000108460a29
> WebCore::Document::Document(WebCore::Frame*, WebCore::URL const&, unsigned
> int, unsigned int) + 313 (Document.cpp:469)
> 6   com.apple.WebCore             	0x00000001086a6011
> WebCore::HTMLDocument::HTMLDocument(WebCore::Frame*, WebCore::URL const&,
> unsigned char, unsigned int) + 17 (HTMLDocument.cpp:87)
> 7   com.apple.WebCore             	0x000000010847abd7
> WebCore::Document::ensureTemplateDocument() + 135 (type_traits:3561)
> 8   com.apple.WebCore             	0x0000000108720dc3
> WebCore::HTMLTemplateElement::content() const + 35
> (HTMLTemplateElement.cpp:62)
> 9   com.apple.WebCore             	0x0000000108aae932
> WebCore::JSHTMLTemplateElement::visitAdditionalChildren(JSC::SlotVisitor&) +
> 18 (Node.h:614)
> 10  com.apple.JavaScriptCore      	0x000000010c194af2
> JSC::SlotVisitor::drain(WTF::MonotonicTime) + 578 (SlotVisitor.cpp:385)
> 11  com.apple.JavaScriptCore      	0x000000010c19514d
> JSC::SlotVisitor::drainFromShared(JSC::SlotVisitor::SharedDrainMode,
> WTF::MonotonicTime) + 61 (SlotVisitor.cpp:653)
> 12  com.apple.JavaScriptCore      	0x000000010bdba17b
> WTF::SharedTaskFunctor<void (),
> JSC::Heap::runBeginPhase(JSC::GCConductor)::$_11>::run() + 603
> (SlotVisitor.h:258)
> 13  com.apple.JavaScriptCore      	0x000000010c2d339c
> WTF::ParallelHelperClient::runTask(WTF::RefPtr<WTF::SharedTask<void ()> >) +
> 44 (RefPtr.h:79)
> 14  com.apple.JavaScriptCore      	0x000000010c2d3f20
> WTF::ParallelHelperPool::Thread::work() + 48 (utility:766)
> 15  com.apple.JavaScriptCore      	0x000000010c2b3950 WTF::Function<void
> ()>::CallableWrapper<WTF::AutomaticThread::start(WTF::AbstractLocker
> const&)::$_0>::call() + 240 (AutomaticThread.cpp:223)
> 16  com.apple.JavaScriptCore      	0x000000010c2ead3f
> WTF::Thread::entryPoint(WTF::Thread::NewThreadContext*) + 175 (memory:2459)
> 17  com.apple.JavaScriptCore      	0x000000010c2ec369
> WTF::wtfThreadEntryPoint(void*) + 9 (ThreadingPthreads.cpp:203)
> 18  libsystem_pthread.dylib       	0x00007fff92cab99d _pthread_body + 131
> 19  libsystem_pthread.dylib       	0x00007fff92cab91a _pthread_start + 168
> 20  libsystem_pthread.dylib       	0x00007fff92ca9351 thread_start + 13
> 
> This was likely caused by you though:
> https://bugs.webkit.org/show_bug.cgi?id=175006

Truth, tracking fix in https://bugs.webkit.org/show_bug.cgi?id=175111.
Comment 13 WebKit Commit Bot 2017-08-02 20:25:34 PDT
Comment on attachment 317018 [details]
Patch

Clearing flags on attachment: 317018

Committed r220176: <http://trac.webkit.org/changeset/220176>
Comment 14 WebKit Commit Bot 2017-08-02 20:25:35 PDT
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2017-08-02 20:26:48 PDT
<rdar://problem/33692526>