Bug 175084 - [PAL] Move SQL into PAL
Summary: [PAL] Move SQL into PAL
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 175613
Blocks: 174942
  Show dependency treegraph
 
Reported: 2017-08-02 12:22 PDT by Don Olmstead
Modified: 2017-08-15 18:53 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.42 KB, patch)
2017-08-03 13:46 PDT, Don Olmstead
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2017-08-02 12:22:41 PDT
Move platform/sql into PAL.

Currently the contents have dependencies in Module/webdatabase and page/MemoryRelease
Comment 1 Brady Eidson 2017-08-02 23:24:26 PDT
(In reply to Don Olmstead from comment #0)
> Move platform/sql into PAL.
> 
> Currently the contents have dependencies in Module/webdatabase and
> page/MemoryRelease

SQLiteDatabase.cpp includes MemoryRelease.h, but doesn't do anything with it. So that's easy.

I'm not terribly surprised if, at some point, platform/sql got a layering violation towards webdatabase, but it's not immediately obvious what it is just by looking at the code.

Perhaps you could actually share details about your discoveries...?
Comment 2 Don Olmstead 2017-08-03 12:32:37 PDT
(In reply to Brady Eidson from comment #1)
> (In reply to Don Olmstead from comment #0)
> > Move platform/sql into PAL.
> > 
> > Currently the contents have dependencies in Module/webdatabase and
> > page/MemoryRelease
> 
> SQLiteDatabase.cpp includes MemoryRelease.h, but doesn't do anything with
> it. So that's easy.
> 
> I'm not terribly surprised if, at some point, platform/sql got a layering
> violation towards webdatabase, but it's not immediately obvious what it is
> just by looking at the code.
> 
> Perhaps you could actually share details about your discoveries...?

Looks like its just DatabaseAuthorizer that needs to move.
Comment 3 Don Olmstead 2017-08-03 13:46:53 PDT
Created attachment 317147 [details]
Patch

Hopefully fixing xcode
Comment 4 Don Olmstead 2017-08-03 13:51:55 PDT
Grr wrong bug. Ignore this