RESOLVED FIXED 175063
Use MPAVRoutingController instead of deprecated versions.
https://bugs.webkit.org/show_bug.cgi?id=175063
Summary Use MPAVRoutingController instead of deprecated versions.
Jeremy Jones
Reported 2017-08-01 18:43:18 PDT
Use MPAVRoutingController instead of deprecated versions.
Attachments
Patch (10.36 KB, patch)
2017-08-01 18:47 PDT, Jeremy Jones
no flags
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.15 MB, application/zip)
2017-08-01 19:52 PDT, Build Bot
no flags
Archive of layout-test-results from ews113 for mac-elcapitan (2.04 MB, application/zip)
2017-08-02 07:30 PDT, Build Bot
no flags
Patch (10.33 KB, patch)
2017-08-02 10:47 PDT, Jeremy Jones
no flags
Patch (10.30 KB, patch)
2017-08-02 13:23 PDT, Jeremy Jones
thorton: review+
buildbot: commit-queue-
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.32 MB, application/zip)
2017-08-02 14:48 PDT, Build Bot
no flags
Archive of layout-test-results from ews116 for mac-elcapitan (1.85 MB, application/zip)
2017-08-02 15:43 PDT, Build Bot
no flags
Patch for landing. (11.22 KB, patch)
2017-08-02 17:08 PDT, Jeremy Jones
no flags
Patch for landing. (11.47 KB, patch)
2017-08-03 15:51 PDT, Jeremy Jones
no flags
Patch for landing. (8.14 KB, patch)
2017-08-07 16:42 PDT, Jeremy Jones
no flags
Patch for landing. (8.22 KB, patch)
2017-08-09 13:33 PDT, Jeremy Jones
no flags
Patch for landing. (8.39 KB, patch)
2017-08-09 15:05 PDT, Jeremy Jones
no flags
Jeremy Jones
Comment 1 2017-08-01 18:44:11 PDT
Jeremy Jones
Comment 2 2017-08-01 18:47:54 PDT
Build Bot
Comment 3 2017-08-01 19:52:24 PDT
Comment on attachment 316922 [details] Patch Attachment 316922 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4237388 New failing tests: imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html
Build Bot
Comment 4 2017-08-01 19:52:25 PDT
Created attachment 316927 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 5 2017-08-02 07:30:38 PDT
Comment on attachment 316922 [details] Patch Attachment 316922 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4239878 New failing tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html
Build Bot
Comment 6 2017-08-02 07:30:39 PDT
Created attachment 316958 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Jeremy Jones
Comment 7 2017-08-02 10:47:44 PDT
Jeremy Jones
Comment 8 2017-08-02 13:23:12 PDT
Build Bot
Comment 9 2017-08-02 14:48:50 PDT
Comment on attachment 316987 [details] Patch Attachment 316987 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4241689 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.html
Build Bot
Comment 10 2017-08-02 14:48:51 PDT
Created attachment 317004 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Build Bot
Comment 11 2017-08-02 15:43:07 PDT
Comment on attachment 316987 [details] Patch Attachment 316987 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4241939 New failing tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html
Build Bot
Comment 12 2017-08-02 15:43:09 PDT
Created attachment 317019 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Tim Horton
Comment 13 2017-08-02 16:12:05 PDT
Comment on attachment 316987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316987&action=review > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:45 > + WKContentView *_view; // Weak reference. Looks like a raw pointer, not weak, to me! > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:71 > + __block RetainPtr<MPAVRoutingController> routingController = adoptNS([allocMPAVRoutingControllerInstance() initWithName:@"WebKit2 - HTML media element showing AirPlay route picker"]); Maybe drop the 2 :)
Jeremy Jones
Comment 14 2017-08-02 17:08:59 PDT
Created attachment 317036 [details] Patch for landing.
Jeremy Jones
Comment 15 2017-08-02 17:09:54 PDT
(In reply to Tim Horton from comment #13) > Comment on attachment 316987 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316987&action=review > > > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:45 > > + WKContentView *_view; // Weak reference. > > Looks like a raw pointer, not weak, to me! No need to store that. Now just passes the view pointer in when presenting. > > > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:71 > > + __block RetainPtr<MPAVRoutingController> routingController = adoptNS([allocMPAVRoutingControllerInstance() initWithName:@"WebKit2 - HTML media element showing AirPlay route picker"]); > > Maybe drop the 2 :) Gone!
WebKit Commit Bot
Comment 16 2017-08-03 10:37:45 PDT
Comment on attachment 317036 [details] Patch for landing. Clearing flags on attachment: 317036 Committed r220209: <http://trac.webkit.org/changeset/220209>
Matt Lewis
Comment 17 2017-08-03 13:27:57 PDT
Reverted r220209 for reason: This caused internal build failures. Committed r220226: <http://trac.webkit.org/changeset/220226>
Jeremy Jones
Comment 18 2017-08-03 15:51:08 PDT
Created attachment 317170 [details] Patch for landing.
WebKit Commit Bot
Comment 19 2017-08-04 13:07:24 PDT
Comment on attachment 317170 [details] Patch for landing. Clearing flags on attachment: 317170 Committed r220288: <http://trac.webkit.org/changeset/220288>
Matt Lewis
Comment 20 2017-08-04 14:37:16 PDT
Reverted r220288 for reason: This broke multiple builds. Committed r220293: <http://trac.webkit.org/changeset/220293>
Jeremy Jones
Comment 21 2017-08-07 16:42:38 PDT
Created attachment 317500 [details] Patch for landing.
Jeremy Jones
Comment 22 2017-08-09 13:33:54 PDT
Created attachment 317732 [details] Patch for landing.
Jeremy Jones
Comment 23 2017-08-09 15:05:13 PDT
Created attachment 317749 [details] Patch for landing.
WebKit Commit Bot
Comment 24 2017-08-09 16:18:17 PDT
Comment on attachment 317749 [details] Patch for landing. Clearing flags on attachment: 317749 Committed r220496: <http://trac.webkit.org/changeset/220496>
Note You need to log in before you can comment on or make changes to this bug.