Use MPAVRoutingController instead of deprecated versions.
rdar://problem/33301230
Created attachment 316922 [details] Patch
Comment on attachment 316922 [details] Patch Attachment 316922 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4237388 New failing tests: imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html
Created attachment 316927 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 316922 [details] Patch Attachment 316922 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4239878 New failing tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html
Created attachment 316958 [details] Archive of layout-test-results from ews113 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews113 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Created attachment 316972 [details] Patch
Created attachment 316987 [details] Patch
Comment on attachment 316987 [details] Patch Attachment 316987 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4241689 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.html
Created attachment 317004 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 316987 [details] Patch Attachment 316987 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4241939 New failing tests: fast/dom/StyleSheet/detached-sheet-owner-node-link.html
Created attachment 317019 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 316987 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316987&action=review > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:45 > + WKContentView *_view; // Weak reference. Looks like a raw pointer, not weak, to me! > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:71 > + __block RetainPtr<MPAVRoutingController> routingController = adoptNS([allocMPAVRoutingControllerInstance() initWithName:@"WebKit2 - HTML media element showing AirPlay route picker"]); Maybe drop the 2 :)
Created attachment 317036 [details] Patch for landing.
(In reply to Tim Horton from comment #13) > Comment on attachment 316987 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=316987&action=review > > > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:45 > > + WKContentView *_view; // Weak reference. > > Looks like a raw pointer, not weak, to me! No need to store that. Now just passes the view pointer in when presenting. > > > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:71 > > + __block RetainPtr<MPAVRoutingController> routingController = adoptNS([allocMPAVRoutingControllerInstance() initWithName:@"WebKit2 - HTML media element showing AirPlay route picker"]); > > Maybe drop the 2 :) Gone!
Comment on attachment 317036 [details] Patch for landing. Clearing flags on attachment: 317036 Committed r220209: <http://trac.webkit.org/changeset/220209>
Reverted r220209 for reason: This caused internal build failures. Committed r220226: <http://trac.webkit.org/changeset/220226>
Created attachment 317170 [details] Patch for landing.
Comment on attachment 317170 [details] Patch for landing. Clearing flags on attachment: 317170 Committed r220288: <http://trac.webkit.org/changeset/220288>
Reverted r220288 for reason: This broke multiple builds. Committed r220293: <http://trac.webkit.org/changeset/220293>
Created attachment 317500 [details] Patch for landing.
Created attachment 317732 [details] Patch for landing.
Created attachment 317749 [details] Patch for landing.
Comment on attachment 317749 [details] Patch for landing. Clearing flags on attachment: 317749 Committed r220496: <http://trac.webkit.org/changeset/220496>