Bug 175063 - Use MPAVRoutingController instead of deprecated versions.
Summary: Use MPAVRoutingController instead of deprecated versions.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-08-01 18:43 PDT by Jeremy Jones
Modified: 2017-11-02 11:27 PDT (History)
6 users (show)

See Also:


Attachments
Patch (10.36 KB, patch)
2017-08-01 18:47 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.15 MB, application/zip)
2017-08-01 19:52 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews113 for mac-elcapitan (2.04 MB, application/zip)
2017-08-02 07:30 PDT, Build Bot
no flags Details
Patch (10.33 KB, patch)
2017-08-02 10:47 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch (10.30 KB, patch)
2017-08-02 13:23 PDT, Jeremy Jones
thorton: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-elcapitan-wk2 (1.32 MB, application/zip)
2017-08-02 14:48 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews116 for mac-elcapitan (1.85 MB, application/zip)
2017-08-02 15:43 PDT, Build Bot
no flags Details
Patch for landing. (11.22 KB, patch)
2017-08-02 17:08 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch for landing. (11.47 KB, patch)
2017-08-03 15:51 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch for landing. (8.14 KB, patch)
2017-08-07 16:42 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch for landing. (8.22 KB, patch)
2017-08-09 13:33 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff
Patch for landing. (8.39 KB, patch)
2017-08-09 15:05 PDT, Jeremy Jones
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-08-01 18:43:18 PDT
Use MPAVRoutingController instead of deprecated versions.
Comment 1 Jeremy Jones 2017-08-01 18:44:11 PDT
rdar://problem/33301230
Comment 2 Jeremy Jones 2017-08-01 18:47:54 PDT
Created attachment 316922 [details]
Patch
Comment 3 Build Bot 2017-08-01 19:52:24 PDT
Comment on attachment 316922 [details]
Patch

Attachment 316922 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4237388

New failing tests:
imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html
imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html
Comment 4 Build Bot 2017-08-01 19:52:25 PDT
Created attachment 316927 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 5 Build Bot 2017-08-02 07:30:38 PDT
Comment on attachment 316922 [details]
Patch

Attachment 316922 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4239878

New failing tests:
fast/dom/StyleSheet/detached-sheet-owner-node-link.html
Comment 6 Build Bot 2017-08-02 07:30:39 PDT
Created attachment 316958 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 7 Jeremy Jones 2017-08-02 10:47:44 PDT
Created attachment 316972 [details]
Patch
Comment 8 Jeremy Jones 2017-08-02 13:23:12 PDT
Created attachment 316987 [details]
Patch
Comment 9 Build Bot 2017-08-02 14:48:50 PDT
Comment on attachment 316987 [details]
Patch

Attachment 316987 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/4241689

New failing tests:
imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html
imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.html
Comment 10 Build Bot 2017-08-02 14:48:51 PDT
Created attachment 317004 [details]
Archive of layout-test-results from ews106 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6
Comment 11 Build Bot 2017-08-02 15:43:07 PDT
Comment on attachment 316987 [details]
Patch

Attachment 316987 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4241939

New failing tests:
fast/dom/StyleSheet/detached-sheet-owner-node-link.html
Comment 12 Build Bot 2017-08-02 15:43:09 PDT
Created attachment 317019 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 13 Tim Horton 2017-08-02 16:12:05 PDT
Comment on attachment 316987 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316987&action=review

> Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:45
> +    WKContentView *_view; // Weak reference.

Looks like a raw pointer, not weak, to me!

> Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:71
> +    __block RetainPtr<MPAVRoutingController> routingController = adoptNS([allocMPAVRoutingControllerInstance() initWithName:@"WebKit2 - HTML media element showing AirPlay route picker"]);

Maybe drop the 2 :)
Comment 14 Jeremy Jones 2017-08-02 17:08:59 PDT
Created attachment 317036 [details]
Patch for landing.
Comment 15 Jeremy Jones 2017-08-02 17:09:54 PDT
(In reply to Tim Horton from comment #13)
> Comment on attachment 316987 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316987&action=review
> 
> > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:45
> > +    WKContentView *_view; // Weak reference.
> 
> Looks like a raw pointer, not weak, to me!

No need to store that. Now just passes the view pointer in when presenting.

> 
> > Source/WebKit/UIProcess/ios/forms/WKAirPlayRoutePicker.mm:71
> > +    __block RetainPtr<MPAVRoutingController> routingController = adoptNS([allocMPAVRoutingControllerInstance() initWithName:@"WebKit2 - HTML media element showing AirPlay route picker"]);
> 
> Maybe drop the 2 :)

Gone!
Comment 16 WebKit Commit Bot 2017-08-03 10:37:45 PDT
Comment on attachment 317036 [details]
Patch for landing.

Clearing flags on attachment: 317036

Committed r220209: <http://trac.webkit.org/changeset/220209>
Comment 17 Matt Lewis 2017-08-03 13:27:57 PDT
Reverted r220209 for reason:

This caused internal build failures.

Committed r220226: <http://trac.webkit.org/changeset/220226>
Comment 18 Jeremy Jones 2017-08-03 15:51:08 PDT
Created attachment 317170 [details]
Patch for landing.
Comment 19 WebKit Commit Bot 2017-08-04 13:07:24 PDT
Comment on attachment 317170 [details]
Patch for landing.

Clearing flags on attachment: 317170

Committed r220288: <http://trac.webkit.org/changeset/220288>
Comment 20 Matt Lewis 2017-08-04 14:37:16 PDT
Reverted r220288 for reason:

This broke multiple builds.

Committed r220293: <http://trac.webkit.org/changeset/220293>
Comment 21 Jeremy Jones 2017-08-07 16:42:38 PDT
Created attachment 317500 [details]
Patch for landing.
Comment 22 Jeremy Jones 2017-08-09 13:33:54 PDT
Created attachment 317732 [details]
Patch for landing.
Comment 23 Jeremy Jones 2017-08-09 15:05:13 PDT
Created attachment 317749 [details]
Patch for landing.
Comment 24 WebKit Commit Bot 2017-08-09 16:18:17 PDT
Comment on attachment 317749 [details]
Patch for landing.

Clearing flags on attachment: 317749

Committed r220496: <http://trac.webkit.org/changeset/220496>