Summary: Instrument WebGLProgram created/deleted. Tests: - Adding/removing program should trigger ShaderProgramAdded, ShaderProgramRemoved. - Destroying canvas context should trigger ShaderProgramRemoved. - Programs created during script parse should be sent once the frontend is enabled. (subtask of https://webkit.org/b/172624)
Created attachment 316919 [details] Patch
Created attachment 316921 [details] Patch
Attachment 316921 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorShaderProgram.cpp:45: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 316921 [details] Patch Attachment 316921 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4237290 New failing tests: inspector/canvas/shaderProgram-added-removed.html
Created attachment 316925 [details] Archive of layout-test-results from ews102 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews102 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 316921 [details] Patch Attachment 316921 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4237297 New failing tests: inspector/canvas/shaderProgram-added-removed.html
Created attachment 316926 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Created attachment 316930 [details] Patch
Attachment 316930 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorShaderProgram.cpp:45: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to Build Bot from comment #9) > Attachment 316930 [details] did not pass style-queue: > > > ERROR: Source/WebCore/inspector/InspectorShaderProgram.cpp:45: Missing > spaces around : [whitespace/init] [4] > Total errors found: 1 in 22 files > > > If any of these errors are false positives, please file a bug against > check-webkit-style. This is a false positive. See https://webkit.org/b/174315.
Comment on attachment 316930 [details] Patch Attachment 316930 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/4237947 New failing tests: inspector/canvas/shaderProgram-added-removed.html
Created attachment 316932 [details] Archive of layout-test-results from ews101 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 316930 [details] Patch Attachment 316930 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4238279 New failing tests: webgl/1.0.2/conformance/more/conformance/quickCheckAPI-D_G.html inspector/canvas/shaderProgram-added-removed.html
Created attachment 316938 [details] Archive of layout-test-results from ews112 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews112 Port: mac-elcapitan Platform: Mac OS X 10.11.6
Comment on attachment 316930 [details] Patch Attachment 316930 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4238523 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.html
Created attachment 316944 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Restructuring tests to skip WebGL2 on certain platforms.
Created attachment 316998 [details] Patch
Attachment 316998 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorShaderProgram.cpp:45: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 316998 [details] Patch Attachment 316998 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/4242242 New failing tests: imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-basic.any.worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors-worker.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.worker.html imported/w3c/web-platform-tests/fetch/api/basic/mode-no-cors.html imported/w3c/web-platform-tests/fetch/api/cors/cors-origin.any.html imported/w3c/web-platform-tests/fetch/api/cors/cors-no-preflight.any.html
Created attachment 317023 [details] Archive of layout-test-results from ews106 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Comment on attachment 316998 [details] Patch Attachment 316998 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/4242565 New failing tests: webgl/1.0.2/conformance/more/conformance/quickCheckAPI-D_G.html
Created attachment 317037 [details] Archive of layout-test-results from ews116 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews116 Port: mac-elcapitan Platform: Mac OS X 10.11.6
(In reply to Build Bot from comment #22) > Comment on attachment 316998 [details] > Patch > > Attachment 316998 [details] did not pass mac-debug-ews (mac): > Output: http://webkit-queues.webkit.org/results/4242565 > > New failing tests: > webgl/1.0.2/conformance/more/conformance/quickCheckAPI-D_G.html This is hitting ASSERT_NOT_REACHED() in InspectorCanvasAgent::willDeleteProgram. Fixing.
(In reply to Matt Baker from comment #24) > (In reply to Build Bot from comment #22) > > Comment on attachment 316998 [details] > > Patch > > > > Attachment 316998 [details] did not pass mac-debug-ews (mac): > > Output: http://webkit-queues.webkit.org/results/4242565 > > > > New failing tests: > > webgl/1.0.2/conformance/more/conformance/quickCheckAPI-D_G.html > > This is hitting ASSERT_NOT_REACHED() in > InspectorCanvasAgent::willDeleteProgram. Fixing. Asserting here is incorrect. This can be called if a program is removed twice. Reduced test: <script> let canvas = document.createElement("canvas"); let ctx = canvas.getContext("webgl"); let program = ctx.createProgram(); ctx.deleteProgram(program); ctx.deleteProgram(program); </script></script>
Created attachment 317054 [details] Patch
Attachment 317054 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorShaderProgram.cpp:45: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 317081 [details] Patch
Attachment 317081 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorShaderProgram.cpp:45: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 317090 [details] Patch
Attachment 317090 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorShaderProgram.cpp:45: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 317091 [details] Patch
Attachment 317091 [details] did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorShaderProgram.cpp:45: Missing spaces around : [whitespace/init] [4] Total errors found: 1 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 317091 [details] Patch r=me
Comment on attachment 317091 [details] Patch Clearing flags on attachment: 317091 Committed r220233: <http://trac.webkit.org/changeset/220233>
All reviewed patches have been landed. Closing bug.
<rdar://problem/33710683>
(In reply to WebKit Commit Bot from comment #35) > Comment on attachment 317091 [details] > Patch > > Clearing flags on attachment: 317091 > > Committed r220233: <http://trac.webkit.org/changeset/220233> This change caused an assertion failure with LayoutTest fast/canvas/webgl/webgl-draw-buffers.html https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/r220268%20(2799)/results.html ASSERTION FAILED: program /Volumes/Data/slave/sierra-debug/build/Source/WebCore/html/canvas/WebGLRenderingContextBase.cpp(1578) : void WebCore::WebGLRenderingContextBase::deleteProgram(WebCore::WebGLProgram *) 1 0x1048a455d WTFCrash 2 0x10d901aa7 WebCore::WebGLRenderingContextBase::deleteProgram(WebCore::WebGLProgram*) 3 0x10c7feed2 WebCore::jsWebGLRenderingContextPrototypeFunctionDeleteProgramBody(JSC::ExecState*, WebCore::JSWebGLRenderingContext*, JSC::ThrowScope&) 4 0x10c7e64fe long long WebCore::IDLOperation<WebCore::JSWebGLRenderingContext>::call<&(WebCore::jsWebGLRenderingContextPrototypeFunctionDeleteProgramBody(JSC::ExecState*, WebCore::JSWebGLRenderingContext*, JSC::ThrowScope&)), (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState&, char const*) 5 0x10c7e628c WebCore::jsWebGLRenderingContextPrototypeFunctionDeleteProgram(JSC::ExecState*) 6 0x4847b0801028 7 0x10442c06d llint_entry 8 0x10442c06d llint_entry 9 0x10442c0e7 llint_entry 10 0x10442c0e7 llint_entry 11 0x10442c0e7 llint_entry 12 0x1044245a7 vmEntryToJavaScript 13 0x1041fe76e JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) 14 0x1041adb9d JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*) 15 0x103a37798 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 16 0x103a37960 JSC::profiledEvaluate(JSC::ExecState*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 17 0x10d20fc2b WebCore::JSMainThreadExecState::profiledEvaluate(JSC::ExecState*, JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) 18 0x10d20fa18 WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, WebCore::DOMWrapperWorld&, WebCore::ExceptionDetails*) 19 0x10d20fd0d WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&, WebCore::ExceptionDetails*) 20 0x10d2253b2 WebCore::ScriptElement::executeClassicScript(WebCore::ScriptSourceCode const&) 21 0x10d2239bf WebCore::ScriptElement::prepareScript(WTF::TextPosition const&, WebCore::ScriptElement::LegacyTypeSupport) 22 0x10b9dc900 WebCore::HTMLScriptRunner::runScript(WebCore::ScriptElement&, WTF::TextPosition const&) 23 0x10b9dc76f WebCore::HTMLScriptRunner::execute(WTF::Ref<WebCore::ScriptElement>&&, WTF::TextPosition const&) 24 0x10b900982 WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() 25 0x10b900ee3 WebCore::HTMLDocumentParser::pumpTokenizerLoop(WebCore::HTMLDocumentParser::SynchronousMode, bool, WebCore::PumpSession&) 26 0x10b8ffb78 WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser::SynchronousMode) 27 0x10b8ff6cb WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore::HTMLDocumentParser::SynchronousMode) 28 0x10b9021ea WebCore::HTMLDocumentParser::append(WTF::RefPtr<WTF::StringImpl>&&) 29 0x10b2f0c02 WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter&, char const*, unsigned long) 30 0x10b4375a9 WebCore::DocumentWriter::addData(char const*, unsigned long) 31 0x10b3edc6f WebCore::DocumentLoader::commitData(char const*, unsigned long)
(In reply to Ryan Haddad from comment #38) > (In reply to WebKit Commit Bot from comment #35) > > Comment on attachment 317091 [details] > > Patch > > > > Clearing flags on attachment: 317091 > > > > Committed r220233: <http://trac.webkit.org/changeset/220233> > This change caused an assertion failure with LayoutTest > fast/canvas/webgl/webgl-draw-buffers.html > https://build.webkit.org/results/Apple%20Sierra%20Debug%20WK1%20(Tests)/ > r220268%20(2799)/results.html > > ASSERTION FAILED: program > /Volumes/Data/slave/sierra-debug/build/Source/WebCore/html/canvas/ > WebGLRenderingContextBase.cpp(1578) : void > WebCore::WebGLRenderingContextBase::deleteProgram(WebCore::WebGLProgram *) > 1 0x1048a455d WTFCrash > 2 0x10d901aa7 > WebCore::WebGLRenderingContextBase::deleteProgram(WebCore::WebGLProgram*) > 3 0x10c7feed2 > WebCore::jsWebGLRenderingContextPrototypeFunctionDeleteProgramBody(JSC:: > ExecState*, WebCore::JSWebGLRenderingContext*, JSC::ThrowScope&) > 4 0x10c7e64fe long long > WebCore::IDLOperation<WebCore::JSWebGLRenderingContext>::call<&(WebCore:: > jsWebGLRenderingContextPrototypeFunctionDeleteProgramBody(JSC::ExecState*, > WebCore::JSWebGLRenderingContext*, JSC::ThrowScope&)), > (WebCore::CastedThisErrorBehavior)0>(JSC::ExecState&, char const*) > 5 0x10c7e628c > WebCore::jsWebGLRenderingContextPrototypeFunctionDeleteProgram(JSC:: > ExecState*) > 6 0x4847b0801028 > 7 0x10442c06d llint_entry > 8 0x10442c06d llint_entry > 9 0x10442c0e7 llint_entry > 10 0x10442c0e7 llint_entry > 11 0x10442c0e7 llint_entry > 12 0x1044245a7 vmEntryToJavaScript > 13 0x1041fe76e JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) > 14 0x1041adb9d JSC::Interpreter::executeProgram(JSC::SourceCode const&, > JSC::ExecState*, JSC::JSObject*) > 15 0x103a37798 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, > JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) > 16 0x103a37960 JSC::profiledEvaluate(JSC::ExecState*, JSC::ProfilingReason, > JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) > 17 0x10d20fc2b > WebCore::JSMainThreadExecState::profiledEvaluate(JSC::ExecState*, > JSC::ProfilingReason, JSC::SourceCode const&, JSC::JSValue, > WTF::NakedPtr<JSC::Exception>&) > 18 0x10d20fa18 > WebCore::ScriptController::evaluateInWorld(WebCore::ScriptSourceCode const&, > WebCore::DOMWrapperWorld&, WebCore::ExceptionDetails*) > 19 0x10d20fd0d > WebCore::ScriptController::evaluate(WebCore::ScriptSourceCode const&, > WebCore::ExceptionDetails*) > 20 0x10d2253b2 > WebCore::ScriptElement::executeClassicScript(WebCore::ScriptSourceCode > const&) > 21 0x10d2239bf WebCore::ScriptElement::prepareScript(WTF::TextPosition > const&, WebCore::ScriptElement::LegacyTypeSupport) > 22 0x10b9dc900 > WebCore::HTMLScriptRunner::runScript(WebCore::ScriptElement&, > WTF::TextPosition const&) > 23 0x10b9dc76f > WebCore::HTMLScriptRunner::execute(WTF::Ref<WebCore::ScriptElement>&&, > WTF::TextPosition const&) > 24 0x10b900982 WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder() > 25 0x10b900ee3 > WebCore::HTMLDocumentParser::pumpTokenizerLoop(WebCore::HTMLDocumentParser:: > SynchronousMode, bool, WebCore::PumpSession&) > 26 0x10b8ffb78 > WebCore::HTMLDocumentParser::pumpTokenizer(WebCore::HTMLDocumentParser:: > SynchronousMode) > 27 0x10b8ff6cb > WebCore::HTMLDocumentParser::pumpTokenizerIfPossible(WebCore:: > HTMLDocumentParser::SynchronousMode) > 28 0x10b9021ea > WebCore::HTMLDocumentParser::append(WTF::RefPtr<WTF::StringImpl>&&) > 29 0x10b2f0c02 > WebCore::DecodedDataDocumentParser::appendBytes(WebCore::DocumentWriter&, > char const*, unsigned long) > 30 0x10b4375a9 WebCore::DocumentWriter::addData(char const*, unsigned long) > 31 0x10b3edc6f WebCore::DocumentLoader::commitData(char const*, unsigned > long) Fixed: https://bugs.webkit.org/show_bug.cgi?id=175196.