WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
175058
Web Inspector: simplify WebInspector with WI
https://bugs.webkit.org/show_bug.cgi?id=175058
Summary
Web Inspector: simplify WebInspector with WI
Devin Rousso
Reported
2017-08-01 16:47:34 PDT
This removes a HUGE number of characters. There really is no reason to have such a large namespace string. WebInspector => 12 characters WI => 2 characters Reduced the minified Main.js by approximately 3.6%. =D
Attachments
Patch
(3.83 MB, patch)
2017-08-01 16:48 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Patch
(3.83 MB, patch)
2017-08-01 16:57 PDT
,
Devin Rousso
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from ews121 for ios-simulator-wk2
(971.88 KB, application/zip)
2017-08-01 18:15 PDT
,
Build Bot
no flags
Details
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Devin Rousso
Comment 1
2017-08-01 16:48:43 PDT
Created
attachment 316911
[details]
Patch
Joseph Pecoraro
Comment 2
2017-08-01 16:56:28 PDT
Comment on
attachment 316911
[details]
Patch
> - <script src="../../UserInterface/Base/WebInspector.js"></script> > + <script src="../../UserInterface/Base/WI.js"></script>
Oops.
Devin Rousso
Comment 3
2017-08-01 16:57:54 PDT
Created
attachment 316915
[details]
Patch
Joseph Pecoraro
Comment 4
2017-08-01 16:59:21 PDT
Comment on
attachment 316915
[details]
Patch r=me
Build Bot
Comment 5
2017-08-01 18:15:38 PDT
Comment on
attachment 316915
[details]
Patch
Attachment 316915
[details]
did not pass ios-sim-ews (ios-simulator-wk2): Output:
http://webkit-queues.webkit.org/results/4236935
New failing tests: imported/blink/fast/dom/HTMLImageElement/image-sizes-viewport-with-template-parent.html
Build Bot
Comment 6
2017-08-01 18:15:40 PDT
Created
attachment 316920
[details]
Archive of layout-test-results from ews121 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews121 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Devin Rousso
Comment 7
2017-08-01 19:38:47 PDT
Comment on
attachment 316915
[details]
Patch Test failures are unrelated.
WebKit Commit Bot
Comment 8
2017-08-01 20:10:55 PDT
Comment on
attachment 316915
[details]
Patch Clearing flags on attachment: 316915 Committed
r220119
: <
http://trac.webkit.org/changeset/220119
>
WebKit Commit Bot
Comment 9
2017-08-01 20:10:56 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10
2017-08-01 20:12:34 PDT
<
rdar://problem/33668888
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug