Bug 175046 - WKPDFView doesn't respect safe area insets
Summary: WKPDFView doesn't respect safe area insets
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2017-08-01 14:38 PDT by Tim Horton
Modified: 2017-08-02 11:10 PDT (History)
3 users (show)

See Also:

Patch (11.35 KB, patch)
2017-08-01 14:38 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (11.87 KB, patch)
2017-08-01 14:54 PDT, Tim Horton
wenson_hsieh: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-08-01 14:38:36 PDT
WKPDFView doesn't respect safe area insets
Comment 1 Tim Horton 2017-08-01 14:38:57 PDT
Created attachment 316896 [details]
Comment 2 Tim Horton 2017-08-01 14:39:12 PDT
Comment 3 Tim Horton 2017-08-01 14:54:51 PDT
Created attachment 316899 [details]
Comment 4 Tim Horton 2017-08-02 10:51:51 PDT
Comment 5 Wenson Hsieh 2017-08-02 10:57:56 PDT
Comment on attachment 316899 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=316899&action=review

A minor follow-up question:

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1271
> +        [self _didChangeAvoidsUnsafeArea:NO];

I assume it's OK to call this, even though WebPageProxy's m_avoidsUnsafeArea may not have actually changed?

> Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm:1286
> +        [self _didChangeAvoidsUnsafeArea:_page->avoidsUnsafeArea()];

Comment 6 Tim Horton 2017-08-02 11:10:19 PDT
Yes, it's fine, just a little extra work. And we're already swapping out the content view, so it's not significant in the grand scheme of things.