Bug 175039 – All C++ accesses to JSObject::m_butterfly should do caging

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

...

[Filip Pizlo]

Created attachment 316975 [details]
the patch

[Radar WebKit Bug Importer]

<rdar://problem/33680363>

[Build Bot]

Comment on attachment 316975 [details]
the patch

Attachment 316975 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4241120

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 316984 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Filip Pizlo]

Created attachment 316985 [details]
the patch

[Filip Pizlo]

Comment on attachment 316985 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316985&action=review

> Source/JavaScriptCore/runtime/JSObject.h:1050
>      // FIXME: This should do caging.
>      // https://bugs.webkit.org/show_bug.cgi?id=175039

I'll remove this comment.

[Keith Miller]

Comment on attachment 316985 [details]
the patch

r=me.

[Build Bot]

Comment on attachment 316985 [details]
the patch

Attachment 316985 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4241556

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 316995 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Filip Pizlo]

Created attachment 317006 [details]
WRONG PATCH

[Filip Pizlo]

Comment on attachment 317006 [details]
WRONG PATCH

It's alraedy been reviewed.

[Filip Pizlo]

Created attachment 317008 [details]
maybe patch for landing

[Build Bot]

Comment on attachment 317008 [details]
maybe patch for landing

Attachment 317008 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4242763

New failing tests:
fast/dom/StyleSheet/detached-sheet-owner-node-link.html

[Build Bot]

Created attachment 317048 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Filip Pizlo]

OK, these failures don't have anything to do with me.

[Filip Pizlo]

Landed in https://trac.webkit.org/changeset/220165/webkit