Bug 175039 - All C++ accesses to JSObject::m_butterfly should do caging
Summary: All C++ accesses to JSObject::m_butterfly should do caging
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords: InRadar
Depends on:
Blocks: 174917
  Show dependency tree / graph
 
Reported: 2017-08-01 11:29 PDT by Filip Pizlo
Modified: 2017-08-02 18:32 PDT (History)
3 users (show)

See Also:

Attachments
the patch (24.72 KB, patch)
2017-08-02 11:00 PDT, Filip Pizlo 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews116 for mac-elcapitan (477.94 KB, application/zip)
2017-08-02 12:48 PDT, Build Bot 		no flags Details
the patch (24.74 KB, patch)
2017-08-02 12:50 PDT, Filip Pizlo 		keith_miller: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews113 for mac-elcapitan (627.87 KB, application/zip)
2017-08-02 14:33 PDT, Build Bot 		no flags Details
WRONG PATCH (5.47 KB, patch)
2017-08-02 14:58 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
maybe patch for landing (24.74 KB, patch)
2017-08-02 14:58 PDT, Filip Pizlo 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews114 for mac-elcapitan (1.88 MB, application/zip)
2017-08-02 17:59 PDT, Build Bot 		no flags Details
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2017-08-01 11:29:07 PDT 
...
Comment 1 Filip Pizlo 2017-08-02 11:00:40 PDT 
Created attachment 316975 [details]
the patch
Comment 2 Radar WebKit Bug Importer 2017-08-02 11:01:01 PDT 
<rdar://problem/33680363>
Comment 3 Build Bot 2017-08-02 12:48:16 PDT 
Comment on attachment 316975 [details]
the patch

Attachment 316975 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4241120

Number of test failures exceeded the failure limit.
Comment 4 Build Bot 2017-08-02 12:48:17 PDT 
Created attachment 316984 [details]
Archive of layout-test-results from ews116 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 5 Filip Pizlo 2017-08-02 12:50:30 PDT 
Created attachment 316985 [details]
the patch
Comment 6 Filip Pizlo 2017-08-02 12:56:23 PDT 
Comment on attachment 316985 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316985&action=review

> Source/JavaScriptCore/runtime/JSObject.h:1050
>      // FIXME: This should do caging.
>      // https://bugs.webkit.org/show_bug.cgi?id=175039

I'll remove this comment.
Comment 7 Keith Miller 2017-08-02 13:08:27 PDT 
Comment on attachment 316985 [details]
the patch

r=me.
Comment 8 Build Bot 2017-08-02 14:33:32 PDT 
Comment on attachment 316985 [details]
the patch

Attachment 316985 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4241556

Number of test failures exceeded the failure limit.
Comment 9 Build Bot 2017-08-02 14:33:33 PDT 
Created attachment 316995 [details]
Archive of layout-test-results from ews113 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 10 Filip Pizlo 2017-08-02 14:58:16 PDT 
Created attachment 317006 [details]
WRONG PATCH
Comment 11 Filip Pizlo 2017-08-02 14:58:34 PDT 
Comment on attachment 317006 [details]
WRONG PATCH

It's alraedy been reviewed.
Comment 12 Filip Pizlo 2017-08-02 14:58:55 PDT 
Created attachment 317008 [details]
maybe patch for landing
Comment 13 Build Bot 2017-08-02 17:59:34 PDT 
Comment on attachment 317008 [details]
maybe patch for landing

Attachment 317008 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/4242763

New failing tests:
fast/dom/StyleSheet/detached-sheet-owner-node-link.html
Comment 14 Build Bot 2017-08-02 17:59:35 PDT 
Created attachment 317048 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6
Comment 15 Filip Pizlo 2017-08-02 18:29:41 PDT 
OK, these failures don't have anything to do with me.
Comment 16 Filip Pizlo 2017-08-02 18:32:24 PDT 
Landed in https://trac.webkit.org/changeset/220165/webkit