Bug 175012 - [PAL][Win] Copy forwarding headers
Summary: [PAL][Win] Copy forwarding headers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-31 22:59 PDT by Yoshiaki Jitsukawa
Modified: 2017-08-01 15:48 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2017-07-31 23:01 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Patch (2.62 KB, patch)
2017-08-01 14:44 PDT, Yoshiaki Jitsukawa 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yoshiaki Jitsukawa 2017-07-31 22:59:17 PDT 
[PAL][Win] Copy forwarding headers
Comment 1 Yoshiaki Jitsukawa 2017-07-31 23:01:51 PDT 
Created attachment 316835 [details]
Patch
Comment 2 Yoshiaki Jitsukawa 2017-07-31 23:16:00 PDT 
This is to prepare for moving the SPI headers from WebCore/platform/spi to PAL.

In the PAL Xcode project, "Copy PAL headers" script copies(rsync) PAL headers. This 
patch is intended to do a similar thing on Windows, mainly for the SPI headers, to 
use the same include paths, for example <pal/spi/cocoa/QuartzCoreSPI.h>.
Comment 3 Myles C. Maxfield 2017-08-01 08:29:34 PDT 
Comment on attachment 316835 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316835&action=review

> Source/WebCore/PAL/pal/PlatformAppleWin.cmake:2
> +#    spi/cf

We don't leave code commented in our checked-in sources.
Comment 4 Yoshiaki Jitsukawa 2017-08-01 14:44:15 PDT 
Created attachment 316897 [details]
Patch
Comment 5 Yoshiaki Jitsukawa 2017-08-01 14:46:03 PDT 
(In reply to Myles C. Maxfield from comment #3)
> Comment on attachment 316835 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316835&action=review
> 
> > Source/WebCore/PAL/pal/PlatformAppleWin.cmake:2
> > +#    spi/cf
> 
> We don't leave code commented in our checked-in sources.

Thank you for reviewing! I removed the lines.
Comment 6 WebKit Commit Bot 2017-08-01 15:33:22 PDT 
Comment on attachment 316897 [details]
Patch

Clearing flags on attachment: 316897

Committed r220113: <http://trac.webkit.org/changeset/220113>
Comment 7 WebKit Commit Bot 2017-08-01 15:33:23 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-08-01 15:48:53 PDT 
<rdar://problem/33664331>