Speedometer has started to fail every time on the perf bot: Running Speedometer (181 of 181) timeout: Speedometer FAILED Finished: 605.017019 s
Do we have any more information on what’s going wrong exactly, or on how the perf bot runs Speedometer exactly?
I do not. Ryosuke likely knows more.
Probably https://trac.webkit.org/changeset/219993.
Tools/Scripts/run-perf-tests PerformanceTests/Speedometer/ to run the test.
One thing I noticed is that https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/"> to PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/dist/index.html. That line wasn’t there before, despite it being part of the corresponding src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15). Was this line manually removed after building previously? If so, we should just remove it from src/index.html.
(In reply to Mathias Bynens from comment #5) > One thing I noticed is that > https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/"> > to > PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/ > dist/index.html. > > That line wasn’t there before, despite it being part of the corresponding > src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15). > > Was this line manually removed after building previously? If so, we should > just remove it from src/index.html. We should do that although I'm not certain it would completely fix it.
(In reply to Ryosuke Niwa from comment #6) > (In reply to Mathias Bynens from comment #5) > > One thing I noticed is that > > https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/"> > > to > > PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/ > > dist/index.html. > > > > That line wasn’t there before, despite it being part of the corresponding > > src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15). > > > > Was this line manually removed after building previously? If so, we should > > just remove it from src/index.html. > > We should do that although I'm not certain it would completely fix it. Patch: https://bugs.webkit.org/show_bug.cgi?id=175004
That fixed it.
<rdar://problem/33656691>