WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED CONFIGURATION CHANGED
174991
REGRESSION (
r219992
-219998): Speedometer fails
https://bugs.webkit.org/show_bug.cgi?id=174991
Summary
REGRESSION (r219992-219998): Speedometer fails
Alexey Proskuryakov
Reported
2017-07-31 13:27:20 PDT
Speedometer has started to fail every time on the perf bot: Running Speedometer (181 of 181) timeout: Speedometer FAILED Finished: 605.017019 s
Attachments
Add attachment
proposed patch, testcase, etc.
Mathias Bynens
Comment 1
2017-07-31 13:53:10 PDT
Do we have any more information on what’s going wrong exactly, or on how the perf bot runs Speedometer exactly?
Alexey Proskuryakov
Comment 2
2017-07-31 14:54:41 PDT
I do not. Ryosuke likely knows more.
Ryosuke Niwa
Comment 3
2017-07-31 16:35:07 PDT
Probably
https://trac.webkit.org/changeset/219993
.
Ryosuke Niwa
Comment 4
2017-07-31 16:35:40 PDT
Tools/Scripts/run-perf-tests PerformanceTests/Speedometer/ to run the test.
Mathias Bynens
Comment 5
2017-07-31 16:38:40 PDT
One thing I noticed is that
https://trac.webkit.org/changeset/219993/webkit#file2
added <base href="/"> to PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/dist/index.html. That line wasn’t there before, despite it being part of the corresponding src/index.html file (
https://trac.webkit.org/changeset/219993/webkit#file15
). Was this line manually removed after building previously? If so, we should just remove it from src/index.html.
Ryosuke Niwa
Comment 6
2017-07-31 16:40:04 PDT
(In reply to Mathias Bynens from
comment #5
)
> One thing I noticed is that >
https://trac.webkit.org/changeset/219993/webkit#file2
added <base href="/"> > to > PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/ > dist/index.html. > > That line wasn’t there before, despite it being part of the corresponding > src/index.html file (
https://trac.webkit.org/changeset/219993/webkit#file15
). > > Was this line manually removed after building previously? If so, we should > just remove it from src/index.html.
We should do that although I'm not certain it would completely fix it.
Mathias Bynens
Comment 7
2017-07-31 17:02:23 PDT
(In reply to Ryosuke Niwa from
comment #6
)
> (In reply to Mathias Bynens from
comment #5
) > > One thing I noticed is that > >
https://trac.webkit.org/changeset/219993/webkit#file2
added <base href="/"> > > to > > PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/ > > dist/index.html. > > > > That line wasn’t there before, despite it being part of the corresponding > > src/index.html file (
https://trac.webkit.org/changeset/219993/webkit#file15
). > > > > Was this line manually removed after building previously? If so, we should > > just remove it from src/index.html. > > We should do that although I'm not certain it would completely fix it.
Patch:
https://bugs.webkit.org/show_bug.cgi?id=175004
Alexey Proskuryakov
Comment 8
2017-08-01 10:28:13 PDT
That fixed it.
Radar WebKit Bug Importer
Comment 9
2017-08-01 10:29:12 PDT
<
rdar://problem/33656691
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug