Bug 174991 - REGRESSION (r219992-219998): Speedometer fails
Summary: REGRESSION (r219992-219998): Speedometer fails
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on: 175004
Blocks:
  Show dependency treegraph
 
Reported: 2017-07-31 13:27 PDT by Alexey Proskuryakov
Modified: 2017-08-01 10:29 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2017-07-31 13:27:20 PDT
Speedometer has started to fail every time on the perf bot:

Running Speedometer (181 of 181)
timeout: Speedometer
FAILED
Finished: 605.017019 s
Comment 1 Mathias Bynens 2017-07-31 13:53:10 PDT
Do we have any more information on what’s going wrong exactly, or on how the perf bot runs Speedometer exactly?
Comment 2 Alexey Proskuryakov 2017-07-31 14:54:41 PDT
I do not. Ryosuke likely knows more.
Comment 3 Ryosuke Niwa 2017-07-31 16:35:07 PDT
Probably https://trac.webkit.org/changeset/219993.
Comment 4 Ryosuke Niwa 2017-07-31 16:35:40 PDT
Tools/Scripts/run-perf-tests PerformanceTests/Speedometer/ to run the test.
Comment 5 Mathias Bynens 2017-07-31 16:38:40 PDT
One thing I noticed is that https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/"> to PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/dist/index.html.

That line wasn’t there before, despite it being part of the corresponding src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15).

Was this line manually removed after building previously? If so, we should just remove it from src/index.html.
Comment 6 Ryosuke Niwa 2017-07-31 16:40:04 PDT
(In reply to Mathias Bynens from comment #5)
> One thing I noticed is that
> https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/">
> to
> PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/
> dist/index.html.
> 
> That line wasn’t there before, despite it being part of the corresponding
> src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15).
> 
> Was this line manually removed after building previously? If so, we should
> just remove it from src/index.html.

We should do that although I'm not certain it would completely fix it.
Comment 7 Mathias Bynens 2017-07-31 17:02:23 PDT
(In reply to Ryosuke Niwa from comment #6)
> (In reply to Mathias Bynens from comment #5)
> > One thing I noticed is that
> > https://trac.webkit.org/changeset/219993/webkit#file2 added <base href="/">
> > to
> > PerformanceTests/Speedometer/resources/todomvc/architecture-examples/angular/
> > dist/index.html.
> > 
> > That line wasn’t there before, despite it being part of the corresponding
> > src/index.html file (https://trac.webkit.org/changeset/219993/webkit#file15).
> > 
> > Was this line manually removed after building previously? If so, we should
> > just remove it from src/index.html.
> 
> We should do that although I'm not certain it would completely fix it.

Patch: https://bugs.webkit.org/show_bug.cgi?id=175004
Comment 8 Alexey Proskuryakov 2017-08-01 10:28:13 PDT
That fixed it.
Comment 9 Radar WebKit Bug Importer 2017-08-01 10:29:12 PDT
<rdar://problem/33656691>