Bug 174947 – Don't add autoplay restrictions to media elements created in response to user gestures

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Matt Rajca]

Don't add autoplay restrictions to media elements created in response to user gestures.

[Matt Rajca]

This fixes playback on the New York Times homepage (and possibly other sites).

[Matt Rajca]

Created attachment 316665 [details]
Patch

[Eric Carlson]

Comment on attachment 316665 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316665&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:466
> +        const bool isProcessingUserGesture = processingUserGestureForMedia();

Why const for this and not the other bool variables?

> LayoutTests/media/video-create-with-user-gesture.html:17
> +        failTestIn(1000);

Nit: this is probably too short for a heavily laden machine (e.g. a bot). I would set it to something like 10 seconds.

[Matt Rajca]

(In reply to Eric Carlson from comment #3)
> Comment on attachment 316665 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316665&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:466
> > +        const bool isProcessingUserGesture = processingUserGestureForMedia();
> 
> Why const for this and not the other bool variables?

I can change the other ones for consistency. None of these are modified after they're declared.

> 
> > LayoutTests/media/video-create-with-user-gesture.html:17
> > +        failTestIn(1000);
> 
> Nit: this is probably too short for a heavily laden machine (e.g. a bot). I
> would set it to something like 10 seconds.

Will do.

[Matt Rajca]

http://trac.webkit.org/changeset/220035/webkit

[Radar WebKit Bug Importer]

<rdar://problem/33602620>