Bug 174943 – [Curl] Add abstraction layer of cookie jar implementation for Curl port

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Basuke Suzuki]

To switch the implementation of cookie jar interface, add abstraction class to support basic feature of cookie jar and move current file implementation to new concrete class which implement that interface.

[Basuke Suzuki]

Created attachment 317266 [details]
Implemented

To implement further improvement for cookie jar, I've added abstract class to switch easily to new implementation while supporting current method. SQLite implementation will follow.

[Build Bot]

Comment on attachment 317266 [details]
Implemented

Attachment 317266 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4254697

New failing tests:
media/video-canvas-createPattern.html

[Build Bot]

Created attachment 317277 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Basuke Suzuki]

Comment on attachment 317266 [details]
Implemented

I have no idea how I can break ios-sim build by this patch. I'm sure this patch only related to Curl port.

[Brent Fulgham]

Comment on attachment 317266 [details]
Implemented

I don't believe the iOS-sim failure is related to this patch. This seems like a fine refactoring for the CURL ports.

[WebKit Commit Bot]

Comment on attachment 317266 [details]
Implemented

Clearing flags on attachment: 317266

Committed r220351: <http://trac.webkit.org/changeset/220351>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Radar WebKit Bug Importer]

<rdar://problem/33760982>