Bug 174943 - [Curl] Add abstraction layer of cookie jar implementation for Curl port
Summary: [Curl] Add abstraction layer of cookie jar implementation for Curl port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Basuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks: 117300 174942
  Show dependency treegraph
 
Reported: 2017-07-28 10:31 PDT by Basuke Suzuki
Modified: 2017-08-07 13:59 PDT (History)
9 users (show)

See Also:


Attachments
Implemented (12.07 KB, patch)
2017-08-04 12:16 PDT, Basuke Suzuki
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1.06 MB, application/zip)
2017-08-04 13:47 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Basuke Suzuki 2017-07-28 10:31:51 PDT
To switch the implementation of cookie jar interface, add abstraction class to support basic feature of cookie jar and move current file implementation to new concrete class which implement that interface.
Comment 1 Basuke Suzuki 2017-08-04 12:16:53 PDT
Created attachment 317266 [details]
Implemented

To implement further improvement for cookie jar, I've added abstract class to switch easily to new implementation while supporting current method. SQLite implementation will follow.
Comment 2 Build Bot 2017-08-04 13:47:26 PDT
Comment on attachment 317266 [details]
Implemented

Attachment 317266 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4254697

New failing tests:
media/video-canvas-createPattern.html
Comment 3 Build Bot 2017-08-04 13:47:27 PDT
Created attachment 317277 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Basuke Suzuki 2017-08-07 13:01:49 PDT
Comment on attachment 317266 [details]
Implemented

I have no idea how I can break ios-sim build by this patch. I'm sure this patch only related to Curl port.
Comment 5 Brent Fulgham 2017-08-07 13:29:46 PDT
Comment on attachment 317266 [details]
Implemented

I don't believe the iOS-sim failure is related to this patch. This seems like a fine refactoring for the CURL ports.
Comment 6 WebKit Commit Bot 2017-08-07 13:58:54 PDT
Comment on attachment 317266 [details]
Implemented

Clearing flags on attachment: 317266

Committed r220351: <http://trac.webkit.org/changeset/220351>
Comment 7 WebKit Commit Bot 2017-08-07 13:58:55 PDT
All reviewed patches have been landed.  Closing bug.
Comment 8 Radar WebKit Bug Importer 2017-08-07 13:59:47 PDT
<rdar://problem/33760982>