RESOLVED FIXED174928
[iOS DnD] [WK1] Snapshots generated using -[DOMRange renderImageForcingBlackText:] are upside down 
https://bugs.webkit.org/show_bug.cgi?id=174928
Summary [iOS DnD] [WK1] Snapshots generated using -[DOMRange renderImageForcingBlackT...
Wenson Hsieh
Reported 2017-07-27 22:25:37 PDT
<rdar://problem/33584280>
Attachments
Patch (4.99 KB, patch)
2017-07-27 22:54 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-07-27 22:54:01 PDT
Created attachment 316621 [details] Patch
Tim Horton
Comment 2 2017-07-27 23:10:31 PDT
Comment on attachment 316621 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=316621&action=review > Source/WebCore/ChangeLog:25 > + Add a FIXME to point out that having an additional context flip inside the UIGraphicsImageRenderer block results > + in an upside-down drag image being returned from createDragImageFromImage. This image is being flipped elsewhere > + in drag initiation code, which eventually results in the correct orientation; we'll need further investigation > + to remove this extraneous flip. The DragImage code is full of flips in odd places.
WebKit Commit Bot
Comment 3 2017-07-28 00:31:09 PDT
Comment on attachment 316621 [details] Patch Clearing flags on attachment: 316621 Committed r219998: <http://trac.webkit.org/changeset/219998>
WebKit Commit Bot
Comment 4 2017-07-28 00:31:11 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.