WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
Bug 174891
javascript URL link cannot use target
https://bugs.webkit.org/show_bug.cgi?id=174891
Summary
javascript URL link cannot use target
Anne van Kesteren
Reported
2017-07-27 04:57:49 PDT
While writing tests for
https://github.com/whatwg/html/issues/1129
I found that the target attribute is not used for javascript URLs in links.
Attachments
Patch
(6.73 KB, patch)
2020-07-19 13:47 PDT
,
Rob Buis
no flags
Details
Formatted Diff
Diff
Patch
(6.22 KB, patch)
2020-12-22 01:53 PST
,
Rob Buis
ews-feeder
: commit-queue-
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Anne van Kesteren
Comment 1
2017-10-10 22:49:33 PDT
***
Bug 178145
has been marked as a duplicate of this bug. ***
Rob Buis
Comment 2
2020-07-13 10:51:54 PDT
This is interesting but I guess there no tests for it?
Anne van Kesteren
Comment 3
2020-07-14 00:57:34 PDT
See
https://github.com/whatwg/html/issues/1129#issuecomment-318068941
. Maybe it can be done through a popup? Where you follow the link in a popup and it actually targets a frame elsewhere. And then you observe if the popup or the frame changed.
Rob Buis
Comment 4
2020-07-14 08:50:48 PDT
(In reply to Anne van Kesteren from
comment #3
)
> See
https://github.com/whatwg/html/issues/1129#issuecomment-318068941
. Maybe > it can be done through a popup? Where you follow the link in a popup and it > actually targets a frame elsewhere. And then you observe if the popup or the > frame changed.
Thanks, based on that I created
https://github.com/web-platform-tests/wpt/pull/24589
.
Rob Buis
Comment 5
2020-07-19 13:47:51 PDT
Created
attachment 404682
[details]
Patch
EWS Watchlist
Comment 6
2020-07-19 13:48:33 PDT
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see
https://trac.webkit.org/wiki/WPTExportProcess
Rob Buis
Comment 7
2020-12-22 01:53:15 PST
Created
attachment 416655
[details]
Patch
Rob Buis
Comment 8
2020-12-22 13:13:32 PST
The failing test is because javascript: handling is synchronous for the test. Also we do not support yet aborting of pending fetches on new navigations. I wonder how to proceed: - land this with the test marked as timeout, fix later. - fix javascript: handling first (
https://bugs.webkit.org/show_bug.cgi?id=200523
?), possibly aborting of pending fetches, which seems like a tricky change. -
http://bugs.webkit.org/show_bug.cgi?id=16782
seems a bit related too. So I feel this patch is correct, it just show up some existing problems/areas where we do not match the specifications.
Sam Sneddon [:gsnedders]
Comment 9
2021-02-10 05:41:43 PST
This came to my attention from EricLaw tweeting about this:
https://twitter.com/ericlaw/status/1359173838257414151
It appears Chrome changed behaviour in 76, from
https://bugs.chromium.org/p/chromium/issues/detail?id=944213
. It sounds like they also had issues landing the change due to existing problems.
https://wpt.fyi/results/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling-dynamic.html?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=javascript-url-return-value-handling-dynamic.html
shows the current results for the test Rob wrote.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug