Bug 174885 – [macOS] Reeder's defaults font is Times instead of San Francisco

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[macOS] Reeder's defaults font is Times instead of San Francisco

[Myles C. Maxfield]

Created attachment 316529 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/33462483>

[Myles C. Maxfield]

Created attachment 316648 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 316648 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316648&action=review

> Source/WebCore/platform/graphics/FontDescription.cpp:163
> +    if (family1.startsWith('.'))
> +        return StringHash::equal(family1.string(), family2.string());
> +    return ASCIICaseInsensitiveHash::equal(family1, family2);

Please add a comment here with a radar number that references the underlying reason why dot names have to be case sensitive.

> Source/WebCore/platform/graphics/FontDescription.cpp:170
> +    if (family.startsWith('.'))
> +        return StringHash::hash(family.string());
> +    return ASCIICaseInsensitiveHash::hash(family);

And here.

> Source/WebCore/platform/graphics/FontDescription.cpp:177
> +    if (family.startsWith('.'))
> +        return family.string();
> +    return family.string().foldCase();

And here.

[Myles C. Maxfield]

Committed r220009: <http://trac.webkit.org/changeset/220009>

[Michael Catanzaro]

Looks like this test is supposed to be specific to macOS and iOS, right? I'm going to skip it in the global expectations file and mark it as passing for macOS and iOS.