Bug 174882 - PDF page number indicator is very flashy when scrolling
Summary: PDF page number indicator is very flashy when scrolling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-26 19:45 PDT by Tim Horton
Modified: 2017-07-27 10:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.19 KB, patch)
2017-07-26 19:46 PDT, Tim Horton 		aestes: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2017-07-26 19:45:57 PDT 
PDF page number indicator is very flashy when scrolling
Comment 1 Tim Horton 2017-07-26 19:46:22 PDT 
Created attachment 316507 [details]
Patch
Comment 2 Tim Horton 2017-07-26 19:46:58 PDT 
<rdar://problem/23760981>
Comment 3 Andy Estes 2017-07-27 10:02:19 PDT 
Comment on attachment 316507 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316507&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:743
> +@interface _UIBackdropViewSettings()

Needs a space before ().

> Source/WebKit/UIProcess/ios/WKPDFPageNumberIndicator.mm:69
> +    _backdropView = adoptNS([[_UIBackdropView alloc] initWithSettings:backdropViewSettings]);

Looks like you need to declare -initWithSettings: in UIKitSPI.h.
Comment 4 Tim Horton 2017-07-27 10:06:31 PDT 
https://trac.webkit.org/changeset/219985/webkit