Bug 174877 - ResourceLoadStatistics API tests fail on El Capitan
Summary: ResourceLoadStatistics API tests fail on El Capitan
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-26 15:17 PDT by Brady Eidson
Modified: 2017-07-27 16:14 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.49 KB, patch)
2017-07-26 16:26 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (964.63 KB, application/zip)
2017-07-26 17:51 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-07-26 15:17:07 PDT 
ResourceLoadStatistics API tests fail on El Capitan

The reason is El Cap doesn't have cookie storage partitioning, and in that case we neglected to send the testing callback in. Doh!
Comment 1 Brady Eidson 2017-07-26 16:26:19 PDT 
Created attachment 316496 [details]
Patch
Comment 2 Build Bot 2017-07-26 17:51:31 PDT 
Comment on attachment 316496 [details]
Patch

Attachment 316496 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/4193207

New failing tests:
imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
Comment 3 Build Bot 2017-07-26 17:51:32 PDT 
Created attachment 316499 [details]
Archive of layout-test-results from ews123 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews123  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5
Comment 4 Brady Eidson 2017-07-26 19:18:18 PDT 
(In reply to Build Bot from comment #2)
> Comment on attachment 316496 [details]
> Patch
> 
> Attachment 316496 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: http://webkit-queues.webkit.org/results/4193207
> 
> New failing tests:
> imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html

Absolutely, positively not from this patch.
Comment 5 WebKit Commit Bot 2017-07-26 19:47:23 PDT 
Comment on attachment 316496 [details]
Patch

Clearing flags on attachment: 316496

Committed r219974: <http://trac.webkit.org/changeset/219974>
Comment 6 WebKit Commit Bot 2017-07-26 19:47:25 PDT 
All reviewed patches have been landed.  Closing bug.