Bug 174855 - [CMake] WebKitFS.cmake depends on options set in Option cmake files that are included later
Summary: [CMake] WebKitFS.cmake depends on options set in Option cmake files that are ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, InRadar
Depends on:
Blocks:
 
Reported: 2017-07-26 01:35 PDT by Carlos Garcia Campos
Modified: 2017-08-01 02:00 PDT (History)
5 users (show)

See Also:

Attachments
Patch (6.11 KB, patch)
2017-07-31 13:47 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-07-26 01:35:25 PDT 
WebKitFS.cmake creates the derived sources directories for WebCore, WebKit and WebDriver, but checking ENABLE options that are set in OptionPort files included later. We are already creating those directories in the specirfic makefiles of WebCore, WebKit and WebDriver, probably as a workaround to this. So, we should either create the directories unconditionally in WebKitFS (it's just a hamrless empty dir in case the option is not enabled) and remove the MAKE_DIRECTORY from all other makefiles, or keep it in the other makefiles and simply remove them from WebKitFS.cmake.
Comment 1 Michael Catanzaro 2017-07-31 13:47:44 PDT 
Created attachment 316798 [details]
Patch
Comment 2 WebKit Commit Bot 2017-08-01 01:08:59 PDT 
Comment on attachment 316798 [details]
Patch

Clearing flags on attachment: 316798

Committed r220091: <http://trac.webkit.org/changeset/220091>
Comment 3 WebKit Commit Bot 2017-08-01 01:09:01 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2017-08-01 01:09:34 PDT 
<rdar://problem/33648858>
Comment 5 Michael Catanzaro 2017-08-01 02:00:32 PDT 
Why was this imported to rdar? Did it break something?