Bug 174851 - Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics
Summary: Add test to verify certain child processes are not launched as a side effect ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-07-25 23:09 PDT by Brady Eidson
Modified: 2017-07-26 13:00 PDT (History)
3 users (show)

See Also:


Attachments
Patch (6.73 KB, patch)
2017-07-26 10:40 PDT, Brady Eidson
cdumez: review+
Details | Formatted Diff | Diff
For landing after EWS (6.73 KB, text/plain)
2017-07-26 11:10 PDT, Brady Eidson
no flags Details
Patch (6.78 KB, patch)
2017-07-26 11:12 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff
Patch (6.78 KB, patch)
2017-07-26 11:48 PDT, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2017-07-25 23:09:13 PDT
Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics 

Followup to https://trac.webkit.org/changeset/219904/webkit
Comment 1 Brady Eidson 2017-07-25 23:25:27 PDT
Namely Databases and Plugin processes.
Comment 2 Brady Eidson 2017-07-26 10:40:03 PDT
Created attachment 316453 [details]
Patch
Comment 3 Chris Dumez 2017-07-26 10:57:13 PDT
Comment on attachment 316453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316453&action=review

r=me with comment.

> Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:126
> +    EXPECT_EQ([sharedProcessPool _databaseProcessIdentifier], (pid_t)0);

The version of gtest we're using seems to still expect the expected value to come first?

from gtest.h
#define EXPECT_EQ(expected, actual) ...
Comment 4 Brady Eidson 2017-07-26 11:10:32 PDT
Created attachment 316456 [details]
For landing after EWS
Comment 5 Brady Eidson 2017-07-26 11:12:16 PDT
Created attachment 316457 [details]
Patch
Comment 6 Brady Eidson 2017-07-26 11:48:59 PDT
Created attachment 316460 [details]
Patch
Comment 7 WebKit Commit Bot 2017-07-26 13:00:06 PDT
Comment on attachment 316460 [details]
Patch

Clearing flags on attachment: 316460

Committed r219958: <http://trac.webkit.org/changeset/219958>
Comment 8 WebKit Commit Bot 2017-07-26 13:00:08 PDT
All reviewed patches have been landed.  Closing bug.