Bug 174850 - Don't override _allowsMediaDocumentInlinePlayback in MediaDocument with playsinlineAttr
Summary: Don't override _allowsMediaDocumentInlinePlayback in MediaDocument with plays...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-25 18:19 PDT by Jeremy Jones
Modified: 2017-11-02 11:32 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.73 KB, patch)
2017-07-25 18:24 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch (4.22 KB, patch)
2017-07-27 18:23 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Patch for landing. (3.69 KB, patch)
2017-07-27 21:01 PDT, Jeremy Jones 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2017-07-25 18:19:46 PDT 
Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr.
Comment 1 Jeremy Jones 2017-07-25 18:21:07 PDT 
rdar://problem/33449903
Comment 2 Jeremy Jones 2017-07-25 18:24:00 PDT 
Created attachment 316415 [details]
Patch
Comment 3 Jeremy Jones 2017-07-27 18:23:33 PDT 
Created attachment 316589 [details]
Patch
Comment 4 Jon Lee 2017-07-27 20:10:58 PDT 
Comment on attachment 316589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316589&action=review

> Source/WebCore/ChangeLog:3
> +        Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr.

MediaDocument.

> Source/WebCore/ChangeLog:9
> +        This change removes playsinlineAttr from MediaDocuemnt so that it doesn't override the setting

MediaDocument

> Source/WebCore/ChangeLog:24
> +2017-07-25  Jeremy Jones  <jeremyj@apple.com>

Double.
Comment 5 Jeremy Jones 2017-07-27 21:00:31 PDT 
(In reply to Jon Lee from comment #4)
> Comment on attachment 316589 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316589&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr.
> 
> MediaDocument.

Fixed.

> 
> > Source/WebCore/ChangeLog:9
> > +        This change removes playsinlineAttr from MediaDocuemnt so that it doesn't override the setting
> 
> MediaDocument

Fixed.

> 
> > Source/WebCore/ChangeLog:24
> > +2017-07-25  Jeremy Jones  <jeremyj@apple.com>
> 
> Double.

Removed.
Comment 6 Jeremy Jones 2017-07-27 21:01:05 PDT 
Created attachment 316611 [details]
Patch for landing.
Comment 7 WebKit Commit Bot 2017-07-27 21:41:17 PDT 
Comment on attachment 316611 [details]
Patch for landing.

Clearing flags on attachment: 316611

Committed r219992: <http://trac.webkit.org/changeset/219992>