Bug 174850 – Don't override _allowsMediaDocumentInlinePlayback in MediaDocument with playsinlineAttr

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr.

[Jeremy Jones]

rdar://problem/33449903

[Jeremy Jones]

Created attachment 316415 [details]
Patch

[Jeremy Jones]

Created attachment 316589 [details]
Patch

[Jon Lee]

Comment on attachment 316589 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316589&action=review

> Source/WebCore/ChangeLog:3
> +        Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr.

MediaDocument.

> Source/WebCore/ChangeLog:9
> +        This change removes playsinlineAttr from MediaDocuemnt so that it doesn't override the setting

MediaDocument

> Source/WebCore/ChangeLog:24
> [phone]  Jeremy Jones  <[e-mail]>

Double.

[Jeremy Jones]

(In reply to Jon Lee from comment #4)
> Comment on attachment 316589 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316589&action=review
> 
> > Source/WebCore/ChangeLog:3
> > +        Don't override _allowsMediaDocumentInlinePlayback in MediaDocuemnt with playsinlineAttr.
> 
> MediaDocument.

Fixed.

> 
> > Source/WebCore/ChangeLog:9
> > +        This change removes playsinlineAttr from MediaDocuemnt so that it doesn't override the setting
> 
> MediaDocument

Fixed.

> 
> > Source/WebCore/ChangeLog:24
> > [phone]  Jeremy Jones  <[e-mail]>
> 
> Double.

Removed.

[Jeremy Jones]

Created attachment 316611 [details]
Patch for landing.

[WebKit Commit Bot]

Comment on attachment 316611 [details]
Patch for landing.

Clearing flags on attachment: 316611

Committed r219992: <http://trac.webkit.org/changeset/219992>