Bug 174846 - Remove Broken CompareEq constant folding phase.
Summary: Remove Broken CompareEq constant folding phase.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Miller
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-25 17:09 PDT by Keith Miller
Modified: 2017-08-16 19:58 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.21 KB, patch)
2017-07-25 17:19 PDT, Keith Miller
no flags Details | Formatted Diff | Diff
Patch (2.38 KB, patch)
2017-07-25 17:20 PDT, Keith Miller
sbarati: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Miller 2017-07-25 17:09:38 PDT
This phase is broken because it can lead to patterns that we don't know how to generate.
Comment 1 Keith Miller 2017-07-25 17:11:45 PDT
rdar://problem/32978808
Comment 2 Keith Miller 2017-07-25 17:19:19 PDT
Created attachment 316409 [details]
Patch
Comment 3 Keith Miller 2017-07-25 17:20:41 PDT
Created attachment 316411 [details]
Patch
Comment 4 Saam Barati 2017-07-25 17:34:31 PDT
Comment on attachment 316411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316411&action=review

> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:138
> +                // FIXME: We should add back the broken folding phase here for comparisions with thing we prove one side has type SpecOther. 

thing => things.

Also, please add bug URL or remove FIXME.
Comment 5 Keith Miller 2017-07-25 17:44:25 PDT
Comment on attachment 316411 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316411&action=review

>> Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp:138
>> +                // FIXME: We should add back the broken folding phase here for comparisions with thing we prove one side has type SpecOther. 
> 
> thing => things.
> 
> Also, please add bug URL or remove FIXME.

Fixed.
Comment 6 Keith Miller 2017-07-25 17:49:31 PDT
Landed in: https://trac.webkit.org/changeset/219895/webkit