Bug 174841 - [Apple Pay] Add "carteBancaire" as a supported payment network
Summary: [Apple Pay] Add "carteBancaire" as a supported payment network
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andy Estes
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-07-25 16:00 PDT by Andy Estes
Modified: 2017-07-25 18:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.97 KB, patch)
2017-07-25 16:04 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (6.95 KB, patch)
2017-07-25 16:06 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Patch (7.02 KB, patch)
2017-07-25 16:07 PDT, Andy Estes 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2017-07-25 16:00:49 PDT 
[Apple Pay] Add "carteBancaire" as a supported payment network
Comment 1 Andy Estes 2017-07-25 16:01:46 PDT 
rdar://problem/31935596
Comment 2 Andy Estes 2017-07-25 16:04:26 PDT 
Created attachment 316401 [details]
Patch
Comment 3 Andy Estes 2017-07-25 16:06:43 PDT 
Created attachment 316402 [details]
Patch
Comment 4 Andy Estes 2017-07-25 16:07:58 PDT 
Created attachment 316403 [details]
Patch
Comment 5 Alex Christensen 2017-07-25 16:11:09 PDT 
Comment on attachment 316403 [details]
Patch

r=me
We should not have to maintain a list of financial institutions in WebKit.  Please move to a better place.
Comment 6 Tim Horton 2017-07-25 16:11:33 PDT 
Comment on attachment 316403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316403&action=review

> LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3.html:18
> +          supportedNetworks: ['visa', 'masterCard', 'carteBancaire'],

Why doesn't this change an expected result?
Comment 7 Andy Estes 2017-07-25 16:13:10 PDT 
(In reply to Tim Horton from comment #6)
> Comment on attachment 316403 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316403&action=review
> 
> > LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3.html:18
> > +          supportedNetworks: ['visa', 'masterCard', 'carteBancaire'],
> 
> Why doesn't this change an expected result?

Because "carteBancaire" is a supported network in v3. I added it there as a defense in case we start throwing an error in v3 or later.
Comment 8 Andy Estes 2017-07-25 16:18:50 PDT 
(In reply to Alex Christensen from comment #5)
> Comment on attachment 316403 [details]
> Patch
> 
> r=me
> We should not have to maintain a list of financial institutions in WebKit. 
> Please move to a better place.

We have a radar tracking that (rdar://problem/33244118).

Thanks for the review!
Comment 9 WebKit Commit Bot 2017-07-25 18:03:33 PDT 
Comment on attachment 316403 [details]
Patch

Clearing flags on attachment: 316403

Committed r219896: <http://trac.webkit.org/changeset/219896>
Comment 10 WebKit Commit Bot 2017-07-25 18:03:34 PDT 
All reviewed patches have been landed.  Closing bug.