Bug 174841 – [Apple Pay] Add "carteBancaire" as a supported payment network

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Andy Estes]

[Apple Pay] Add "carteBancaire" as a supported payment network

[Andy Estes]

rdar://problem/31935596

[Andy Estes]

Created attachment 316401 [details]
Patch

[Andy Estes]

Created attachment 316402 [details]
Patch

[Andy Estes]

Created attachment 316403 [details]
Patch

[Alex Christensen]

Comment on attachment 316403 [details]
Patch

r=me
We should not have to maintain a list of financial institutions in WebKit.  Please move to a better place.

[Tim Horton]

Comment on attachment 316403 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=316403&action=review

> LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3.html:18
> +          supportedNetworks: ['visa', 'masterCard', 'carteBancaire'],

Why doesn't this change an expected result?

[Andy Estes]

(In reply to Tim Horton from comment #6)
> Comment on attachment 316403 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=316403&action=review
> 
> > LayoutTests/http/tests/ssl/applepay/ApplePaySessionV3.html:18
> > +          supportedNetworks: ['visa', 'masterCard', 'carteBancaire'],
> 
> Why doesn't this change an expected result?

Because "carteBancaire" is a supported network in v3. I added it there as a defense in case we start throwing an error in v3 or later.

[Andy Estes]

(In reply to Alex Christensen from comment #5)
> Comment on attachment 316403 [details]
> Patch
> 
> r=me
> We should not have to maintain a list of financial institutions in WebKit. 
> Please move to a better place.

We have a radar tracking that (rdar://problem/33244118).

Thanks for the review!

[WebKit Commit Bot]

Comment on attachment 316403 [details]
Patch

Clearing flags on attachment: 316403

Committed r219896: <http://trac.webkit.org/changeset/219896>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.